Skip to content

Commit 553cf7b

Browse files
authored
Add SignatureInformation activeParameter support. (#4643)
1 parent 2216e54 commit 553cf7b

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

lsp-mode.el

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3813,7 +3813,8 @@ disappearing, unset all the variables related to it."
38133813
(labelDetailsSupport . t)))
38143814
(contextSupport . t)
38153815
(dynamicRegistration . t)))
3816-
(signatureHelp . ((signatureInformation . ((parameterInformation . ((labelOffsetSupport . t)))))
3816+
(signatureHelp . ((signatureInformation . ((parameterInformation . ((labelOffsetSupport . t)))
3817+
(activeParameterSupport . t)))
38173818
(dynamicRegistration . t)))
38183819
(documentLink . ((dynamicRegistration . t)
38193820
(tooltipSupport . t)))
@@ -5924,6 +5925,8 @@ It will show up only if current point has signature help."
59245925
(active-signature? (or lsp--signature-last-index active-signature? 0))
59255926
(_ (setq lsp--signature-last-index active-signature?))
59265927
((signature &as &SignatureInformation? :label :parameters?) (seq-elt signatures active-signature?))
5928+
(active-parameter? (or (lsp:signature-information-active-parameter? signature)
5929+
active-parameter?))
59275930
(prefix (if (= (length signatures) 1)
59285931
""
59295932
(concat (propertize (format " %s/%s"

lsp-protocol.el

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -699,7 +699,7 @@ See `-let' for a description of the destructuring mechanism."
699699
(SignatureHelpCapabilities nil (:contextSupport :dynamicRegistration :signatureInformation))
700700
(SignatureHelpContext (:triggerKind :isRetrigger) (:activeSignatureHelp :triggerCharacter))
701701
(SignatureHelpOptions nil (:retriggerCharacters :triggerCharacters))
702-
(SignatureInformation (:label) (:documentation :parameters))
702+
(SignatureInformation (:label) (:documentation :parameters :activeParameter))
703703
(SignatureInformationCapabilities nil (:documentationFormat :parameterInformation))
704704
(StaticRegistrationOptions nil (:documentSelector :id))
705705
(SymbolCapabilities nil (:dynamicRegistration :symbolKind))

0 commit comments

Comments
 (0)