Drop :_emacsStartPoint when calling resolve

Fixes #3956

Author: yyoncho

lsp-completion.el

@@ -701,7 +701,7 @@ See #2675"
   (lsp-completion--fix-resolve-data item)
   (or (ignore-errors
         (when (lsp-feature? "completionItem/resolve")
-          (lsp-request "completionItem/resolve" item)))
+          (lsp-request "completionItem/resolve" (lsp-delete item :_emacsStartPoint))))
       item))
 
 (defun lsp-completion--resolve-async (item callback &optional cleanup-fn)
@@ -711,7 +711,7 @@ The CLEANUP-FN will be called to cleanup."
   (lsp-completion--fix-resolve-data item)
   (ignore-errors
     (if (lsp-feature? "completionItem/resolve")
-        (lsp-request-async "completionItem/resolve" item
+        (lsp-request-async "completionItem/resolve" (lsp-delete item :_emacsStartPoint)
                            (lambda (result)
                              (funcall callback result)
                              (when cleanup-fn (funcall cleanup-fn)))

lsp-protocol.el

@@ -262,7 +262,10 @@ Allowed params: %s" interface (reverse (-map #'cl-first params)))
       (defun lsp-member? (from key)
         (when (listp from)
           (plist-member from key)))
-      (defalias 'lsp-structure-p 'json-plist-p))
+      (defalias 'lsp-structure-p 'json-plist-p)
+      (defun lsp-delete (from key)
+        (cl-remf from key)
+        from))
   (defun lsp-get (from key)
     (when from
       (gethash (lsp-keyword->string key) from)))
@@ -279,7 +282,10 @@ Allowed params: %s" interface (reverse (-map #'cl-first params)))
     (when (hash-table-p from)
       (not (eq (gethash (lsp-keyword->string key) from :__lsp_default)
                :__lsp_default))))
-  (defalias 'lsp-structure-p 'hash-table-p))
+  (defalias 'lsp-structure-p 'hash-table-p)
+  (defun lsp-delete (from key)
+    (ht-remove from (lsp-keyword->string key))
+    from))
 
 (defmacro lsp-defun (name match-form &rest body)
   "Define a function named NAME.