Visual X, deletion column respects stick eol

Author: tomdl89

evil-commands.el

@@ -1510,7 +1510,10 @@ Save in REGISTER or in the kill-ring with YANK-HANDLER."
                ;; Special exceptions to ever saving column:
                (not (memq evil-this-motion '(evil-forward-word-begin
                                              evil-forward-WORD-begin))))
-      (move-to-column evil-operator-start-col))))
+      (move-to-column (if (and (eq most-positive-fixnum temporary-goal-column)
+                               (memq last-command '(next-line previous-line)))
+                          temporary-goal-column
+                        evil-operator-start-col)))))
 
 (evil-define-operator evil-delete-line (beg end type register yank-handler)
   "Delete to end of line."
@@ -1526,7 +1529,13 @@ Save in REGISTER or in the kill-ring with YANK-HANDLER."
         (let ((temporary-goal-column most-positive-fixnum)
               (last-command 'next-line))
           (evil-delete beg end 'block register yank-handler))
-      (evil-delete beg end type register yank-handler))))
+      (evil-delete beg end type register yank-handler)
+      (evil-first-non-blank)
+      (when (and (not evil-start-of-line) evil-operator-start-col)
+        (move-to-column (if (and (eq most-positive-fixnum temporary-goal-column)
+                                 (memq last-command '(next-line previous-line)))
+                            temporary-goal-column
+                          evil-operator-start-col))))))
 
 (evil-define-operator evil-delete-whole-line
   (beg end type register yank-handler)

evil-maps.el

@@ -389,6 +389,7 @@
 (define-key evil-visual-state-map "R" 'evil-change-whole-line)
 (define-key evil-visual-state-map "u" 'evil-downcase)
 (define-key evil-visual-state-map "U" 'evil-upcase)
+(define-key evil-visual-state-map "X" 'evil-delete-line)
 (define-key evil-visual-state-map "z=" 'ispell-word)
 (define-key evil-visual-state-map "a" evil-outer-text-objects-map)
 (define-key evil-visual-state-map "i" evil-inner-text-objects-map)

evil-tests.el

@@ -2135,7 +2135,7 @@ then enter the text in that file's own buffer."))
       ";; This <buffe[r]> is for notes,
 and for Lisp evaluation."
       ("D")
-      "[a]nd for Lisp evaluation."))
+      "and for Lisp [e]valuation."))
   (ert-info ("Act on each line of block selection")
     (evil-test-buffer
       :visual block
@@ -2218,6 +2218,14 @@ ine3 line3      line3 l\n"))
       ("\C-w")
       "alpha [b]ravo charlie delta")))
 
+(ert-deftest evil-test-visual-X ()
+  "Test `X' in visual state."
+  :tags '(evil)
+  (evil-test-buffer
+    "This is line one\nThis is lin[e] two\nThis is line three"
+    ("v$oX")
+    "This is line one\nThis is lin[e] three"))
+
 (ert-deftest evil-test-delete-back-to-indentation ()
   "Test `evil-delete-back-to-indentation' in insert & replace states."
   :tags '(evil)