Merge pull request #4 from danadajian/patch-1

turn on noUncheckedIndexedAccess TS rule

Author: SaltyAom

src/index.ts

@@ -208,17 +208,20 @@ export const cors =
             if (origins.length) {
                 const from = request.headers.get('Origin') ?? ''
                 for (let i = 0; i < origins.length; i++) {
-                    const value = processOrigin(origins[i], request, from)
-                    if (value === true) {
-                        set.headers['Vary'] = origin ? 'Origin' : '*'
-                        set.headers['Access-Control-Allow-Origin'] =
-                            request.headers.get('Origin') ?? '*'
-
-                        return
+                    const currentOrigin = origins[i];
+                    if (currentOrigin) {
+                        const value = processOrigin(currentOrigin, request, from)
+                        if (value === true) {
+                            set.headers['Vary'] = origin ? 'Origin' : '*'
+                            set.headers['Access-Control-Allow-Origin'] =
+                                request.headers.get('Origin') ?? '*'
+
+                            return
+                        }
+
+                        // value can be string (truthy value) but not `true`
+                        if (value) headers.push(value)
                     }
-
-                    // value can be string (truthy value) but not `true`
-                    if (value) headers.push(value)
                 }
             }
 

tsconfig.cjs.json

@@ -90,7 +90,7 @@
     // "exactOptionalPropertyTypes": true,               /* Interpret optional property types as written, rather than adding 'undefined'. */
     // "noImplicitReturns": true,                        /* Enable error reporting for codepaths that do not explicitly return in a function. */
     // "noFallthroughCasesInSwitch": true,               /* Enable error reporting for fallthrough cases in switch statements. */
-    // "noUncheckedIndexedAccess": true,                 /* Add 'undefined' to a type when accessed using an index. */
+   "noUncheckedIndexedAccess": true,                     /* Add 'undefined' to a type when accessed using an index. */
     // "noImplicitOverride": true,                       /* Ensure overriding members in derived classes are marked with an override modifier. */
     // "noPropertyAccessFromIndexSignature": true,       /* Enforces using indexed accessors for keys declared using an indexed type. */
     // "allowUnusedLabels": true,                        /* Disable error reporting for unused labels. */

tsconfig.esm.json

@@ -90,7 +90,7 @@
     // "exactOptionalPropertyTypes": true,               /* Interpret optional property types as written, rather than adding 'undefined'. */
     // "noImplicitReturns": true,                        /* Enable error reporting for codepaths that do not explicitly return in a function. */
     // "noFallthroughCasesInSwitch": true,               /* Enable error reporting for fallthrough cases in switch statements. */
-    // "noUncheckedIndexedAccess": true,                 /* Add 'undefined' to a type when accessed using an index. */
+    "noUncheckedIndexedAccess": true,                    /* Add 'undefined' to a type when accessed using an index. */
     // "noImplicitOverride": true,                       /* Ensure overriding members in derived classes are marked with an override modifier. */
     // "noPropertyAccessFromIndexSignature": true,       /* Enforces using indexed accessors for keys declared using an indexed type. */
     // "allowUnusedLabels": true,                        /* Disable error reporting for unused labels. */

tsconfig.json

@@ -90,7 +90,7 @@
     // "exactOptionalPropertyTypes": true,               /* Interpret optional property types as written, rather than adding 'undefined'. */
     // "noImplicitReturns": true,                        /* Enable error reporting for codepaths that do not explicitly return in a function. */
     // "noFallthroughCasesInSwitch": true,               /* Enable error reporting for fallthrough cases in switch statements. */
-    // "noUncheckedIndexedAccess": true,                 /* Add 'undefined' to a type when accessed using an index. */
+   "noUncheckedIndexedAccess": true,                     /* Add 'undefined' to a type when accessed using an index. */
     // "noImplicitOverride": true,                       /* Ensure overriding members in derived classes are marked with an override modifier. */
     // "noPropertyAccessFromIndexSignature": true,       /* Enforces using indexed accessors for keys declared using an indexed type. */
     // "allowUnusedLabels": true,                        /* Disable error reporting for unused labels. */