fix: use lsp.assings.documents

Author: lucacervello

lib/next_ls.ex

@@ -828,8 +828,10 @@ defmodule NextLS do
         %TextDocumentSignatureHelp{params: %SignatureHelpParams{text_document: %{uri: uri}, position: position}},
         lsp
       ) do
+    text = Enum.join(lsp.assigns.documents[uri], "\n")
+
     signature_help =
-      case SignatureHelp.fetch_mod_and_name(uri, {position.line + 1, position.character + 1}) do
+      case SignatureHelp.fetch_mod_and_name(text, {position.line + 1, position.character + 1}) do
         {:ok, {mod, name}} ->
           docs =
             dispatch(lsp.assigns.registry, :runtimes, fn entries ->

lib/next_ls/signature_help.ex

@@ -8,16 +8,16 @@ defmodule NextLS.SignatureHelp do
   alias GenLSP.Structures.SignatureInformation
   alias NextLS.ASTHelpers
 
-  def fetch_mod_and_name(uri, position) do
-    with {:ok, text} <- File.read(URI.parse(uri).path),
-         ast =
-           text
-           |> Spitfire.parse(literal_encoder: &{:ok, {:__literal__, &2, [&1]}})
-           |> then(fn
-             {:ok, ast} -> ast
-             {:error, ast, _} -> ast
-           end),
-         {:ok, result} <- ASTHelpers.Function.find_remote_function_call_within(ast, position) do
+  def fetch_mod_and_name(text, position) do
+    ast =
+      text
+      |> Spitfire.parse(literal_encoder: &{:ok, {:__literal__, &2, [&1]}})
+      |> then(fn
+        {:ok, ast} -> ast
+        {:error, ast, _} -> ast
+      end)
+
+    with {:ok, result} <- ASTHelpers.Function.find_remote_function_call_within(ast, position) do
       case result do
         {{:., _, [{:__aliases__, _, modules}, name]}, _, _} -> {:ok, {Module.concat(modules), name}}
       end

test/next_ls/signature_help_test.exs

@@ -101,6 +101,9 @@ defmodule NextLS.SignatureHelpTest do
     test "get signature help", %{client: client, bar: bar} do
       uri = uri(bar)
 
+      did_open(client, bar, File.read!(bar))
+      did_change(client, uri)
+
       request(client, %{
         method: "textDocument/signatureHelp",
         id: 4,
@@ -130,6 +133,9 @@ defmodule NextLS.SignatureHelpTest do
     test "get signature help with multiple params", %{client: client, bar: bar} do
       uri = uri(bar)
 
+      did_open(client, bar, File.read!(bar))
+      did_change(client, uri)
+
       request(client, %{
         method: "textDocument/signatureHelp",
         id: 4,
@@ -156,6 +162,9 @@ defmodule NextLS.SignatureHelpTest do
     test "get signature help with parameters on multiple lines", %{client: client, bar: bar} do
       uri = uri(bar)
 
+      did_open(client, bar, File.read!(bar))
+      did_change(client, uri)
+
       request(client, %{
         method: "textDocument/signatureHelp",
         id: 4,

test/support/utils.ex

@@ -172,4 +172,21 @@ defmodule NextLS.Support.Utils do
                })
     end
   end
+
+  defmacro did_change(client, uri) do
+    quote do
+      assert :ok == notify(unquote(client), %{
+      method: "workspace/didChangeWatchedFiles",
+      jsonrpc: "2.0",
+      params: %{
+        changes: [
+          %{
+            type: GenLSP.Enumerations.FileChangeType.changed(),
+            uri: unquote(uri)
+          }
+        ]
+      }
+    })
+    end
+  end
 end