do not use regex in module body

Author: lukaszsamson

apps/language_server/lib/language_server/markdown_utils.ex

@@ -1,10 +1,9 @@
 defmodule ElixirLS.LanguageServer.MarkdownUtils do
   alias ElixirLS.LanguageServer.DocLinks
 
-  @hash_match ~r/(?<!\\)(?<!\w)(#+)(?=\s)/u
   # Find the lowest heading level in the fragment
   defp lowest_heading_level(fragment) do
-    case Regex.scan(@hash_match, fragment) do
+    case Regex.scan(~r/(?<!\\)(?<!\w)(#+)(?=\s)/u, fragment) do
       [] ->
         nil
 
@@ -22,7 +21,7 @@ defmodule ElixirLS.LanguageServer.MarkdownUtils do
     if min_level do
       level_difference = base_level + 1 - min_level
 
-      Regex.replace(@hash_match, fragment, fn _, capture ->
+      Regex.replace(~r/(?<!\\)(?<!\w)(#+)(?=\s)/u, fragment, fn _, capture ->
         adjusted_level = String.length(capture) + level_difference
         String.duplicate("#", adjusted_level)
       end)

apps/language_server/lib/language_server/providers/code_action/helpers.ex

@@ -29,18 +29,17 @@ defmodule ElixirLS.LanguageServer.Providers.CodeAction.Helpers do
     |> Text.fetch_line(0)
   end
 
-  @do_regex ~r/\s*do\s*/
   defp maybe_recover_one_line_do(updated_text, {_name, context, _children} = _updated_ast) do
     wrong_do_end_conditions = [
       not Keyword.has_key?(context, :do),
       not Keyword.has_key?(context, :end),
-      Regex.match?(@do_regex, updated_text),
+      Regex.match?(~r/\s*do\s*/, updated_text),
       String.ends_with?(updated_text, "\nend")
     ]
 
     if Enum.all?(wrong_do_end_conditions) do
       updated_text
-      |> String.replace(@do_regex, ", do: ")
+      |> String.replace(~r/\s*do\s*/, ", do: ")
       |> String.trim_trailing("\nend")
     else
       updated_text

apps/language_server/lib/language_server/providers/code_action/replace_remote_function.ex

@@ -37,9 +37,9 @@ defmodule ElixirLS.LanguageServer.Providers.CodeAction.ReplaceRemoteFunction do
     end
   end
 
-  @function_re ~r/(\S+)\/(\d+) is undefined or private. Did you mean:.*/
   defp extract_function(message) do
-    with [[_, module_and_function, arity]] <- Regex.scan(@function_re, message),
+    with [[_, module_and_function, arity]] <-
+           Regex.scan(~r/(\S+)\/(\d+) is undefined or private. Did you mean:.*/, message),
          {:ok, module, function_name} <- separate_module_from_function(module_and_function) do
       {:ok, module, function_name, String.to_integer(arity)}
     end

apps/language_server/lib/language_server/providers/code_action/replace_with_underscore.ex

@@ -35,9 +35,8 @@ defmodule ElixirLS.LanguageServer.Providers.CodeAction.ReplaceWithUnderscore do
     end
   end
 
-  @variable_re ~r/variable "([^"]+)" is unused/
   defp extract_variable_name(message) do
-    case Regex.scan(@variable_re, message) do
+    case Regex.scan(~r/variable "([^"]+)" is unused/, message) do
       [[_, variable_name]] ->
         {:ok, String.to_atom(variable_name)}
 

apps/language_server/lib/language_server/providers/code_mod/text.ex

@@ -1,18 +1,15 @@
 defmodule ElixirLS.LanguageServer.Providers.CodeMod.Text do
-  @indent_regex ~r/^\s+/
-  @comment_regex ~r/\s*#.*/
-
   @spec leading_indent(String.t()) :: String.t()
   def leading_indent(line_text) do
-    case Regex.scan(@indent_regex, line_text) do
+    case Regex.scan(~r/^\s+/, line_text) do
       [indent] -> indent
       _ -> ""
     end
   end
 
   @spec trailing_comment(String.t()) :: String.t()
   def trailing_comment(line_text) do
-    case Regex.scan(@comment_regex, line_text) do
+    case Regex.scan(~r/\s*#.*/, line_text) do
       [comment] -> comment
       _ -> ""
     end