be more strict when DETS init fails

Author: lukaszsamson

apps/language_server/lib/language_server/server.ex

@@ -155,10 +155,11 @@ defmodule ElixirLS.LanguageServer.Server do
           %{}
         )
 
-        Logger.info("Terminating #{__MODULE__}: #{message}")
+        Logger.error("Terminating #{__MODULE__}: #{message}")
 
         unless Application.get_env(:language_server, :test_mode) do
-          System.stop(1)
+          Process.sleep(2000)
+          System.halt(1)
         end
     end
 
@@ -1462,12 +1463,34 @@ defmodule ElixirLS.LanguageServer.Server do
     # in case we missed something or restarted and don't have old_diagnostics
     # we also push for all open files
     uris_from_old_diagnostics =
-      Enum.map(old_diagnostics, &(&1.file |> SourceFile.Path.to_uri(project_dir)))
+      old_diagnostics
+      |> Enum.reject(&is_nil(&1.file))
+      |> Enum.map(&(&1.file |> SourceFile.Path.to_uri(project_dir)))
 
     new_diagnostics_by_uri =
       new_diagnostics
+      |> Enum.reject(&is_nil(&1.file))
       |> Enum.group_by(&(&1.file |> SourceFile.Path.to_uri(project_dir)))
 
+    invalid_diagnostics =
+      new_diagnostics
+      |> Enum.filter(&is_nil(&1.file))
+
+    # TODO remove when we are sure diagnostic code is correct
+    if invalid_diagnostics != [] do
+      Logger.error("Invalid diagnostic with nil file: #{inspect(hd(invalid_diagnostics))}")
+
+      JsonRpc.telemetry(
+        "lsp_server_error",
+        %{
+          "elixir_ls.lsp_process" => inspect(__MODULE__),
+          "elixir_ls.lsp_server_error" =>
+            "Invalid diagnostic: #{inspect(hd(invalid_diagnostics))}"
+        },
+        %{}
+      )
+    end
+
     uris_from_new_diagnostics = Map.keys(new_diagnostics_by_uri)
 
     uris_from_open_files = Map.keys(source_files)
@@ -1881,7 +1904,24 @@ defmodule ElixirLS.LanguageServer.Server do
          File.dir?(Path.join([project_dir, ".elixir_ls"])) and
          not Tracer.manifest_version_current?(project_dir) do
       Logger.info("DETS databases will be rebuilt")
-      Tracer.clean_dets(project_dir)
+
+      try do
+        Tracer.clean_dets(project_dir)
+      rescue
+        e ->
+          message =
+            "Unable to clean DETS databases in #{project_dir}: #{Exception.message(e)}"
+
+          Logger.error(message)
+
+          JsonRpc.show_message(
+            :error,
+            message
+          )
+
+          Process.sleep(2000)
+          System.halt(1)
+      end
 
       case File.cwd() do
         {:ok, cwd} ->
@@ -1908,6 +1948,9 @@ defmodule ElixirLS.LanguageServer.Server do
                   :error,
                   message
                 )
+
+                Process.sleep(2000)
+                System.halt(1)
             end
           else
             message =
@@ -1919,6 +1962,9 @@ defmodule ElixirLS.LanguageServer.Server do
               :error,
               message
             )
+
+            Process.sleep(2000)
+            System.halt(1)
           end
 
         {:error, reason} ->
@@ -1929,6 +1975,9 @@ defmodule ElixirLS.LanguageServer.Server do
             :error,
             message
           )
+
+          Process.sleep(2000)
+          System.halt(1)
       end
     end
   end

apps/language_server/lib/language_server/tracer.ex

@@ -191,6 +191,28 @@ defmodule ElixirLS.LanguageServer.Tracer do
         Process.sleep(200)
         ^table_name = :dets.to_ets(table_name, table_name)
     end
+  catch
+    kind, payload ->
+      {payload, stacktrace} = Exception.blame(kind, payload, __STACKTRACE__)
+      error_msg = Exception.format(kind, payload, stacktrace)
+
+      Logger.error(
+        "Unable to init tracer table #{table} in directory #{project_dir}: #{error_msg}"
+      )
+
+      JsonRpc.telemetry(
+        "lsp_server_error",
+        %{
+          "elixir_ls.lsp_process" => inspect(__MODULE__),
+          "elixir_ls.lsp_server_error" => error_msg
+        },
+        %{}
+      )
+
+      unless Application.get_env(:language_server, :test_mode) do
+        Process.sleep(2000)
+        System.halt(1)
+      end
   end
 
   def close_table(table, project_dir) do
@@ -204,6 +226,15 @@ defmodule ElixirLS.LanguageServer.Tracer do
 
       {:error, reason} ->
         Logger.error("Unable to close DETS #{path}, #{inspect(reason)}")
+
+        JsonRpc.telemetry(
+          "lsp_server_error",
+          %{
+            "elixir_ls.lsp_process" => inspect(__MODULE__),
+            "elixir_ls.lsp_server_error" => "Unable to close DETS #{path}, #{inspect(reason)}"
+          },
+          %{}
+        )
     end
   end
 
@@ -352,11 +383,17 @@ defmodule ElixirLS.LanguageServer.Tracer do
          :ok <- :dets.sync(table_name) do
       :ok
     else
-      {:error, reason} ->
-        Logger.error("Unable to sync DETS #{table_name}, #{inspect(reason)}")
-
       other ->
         Logger.error("Unable to sync DETS #{table_name}, #{inspect(other)}")
+
+        JsonRpc.telemetry(
+          "lsp_server_error",
+          %{
+            "elixir_ls.lsp_process" => inspect(__MODULE__),
+            "elixir_ls.lsp_server_error" => "Unable to sync DETS #{table_name}, #{inspect(other)}"
+          },
+          %{}
+        )
     end
   end