Skip to content

Commit d2555f1

Browse files
committed
do not crash completions when non valid UTF-8 is returned
1 parent b8c9d7c commit d2555f1

File tree

1 file changed

+10
-4
lines changed
  • apps/language_server/lib/language_server/providers

1 file changed

+10
-4
lines changed

apps/language_server/lib/language_server/providers/hover.ex

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -214,11 +214,17 @@ defmodule ElixirLS.LanguageServer.Providers.Hover do
214214
defp documentation_section(""), do: ""
215215

216216
defp documentation_section(docs) do
217-
"""
218-
### Documentation
217+
if String.valid?(docs) do
218+
"""
219+
### Documentation
219220
220-
#{MarkdownUtils.adjust_headings(docs, 3)}
221-
"""
221+
#{MarkdownUtils.adjust_headings(docs, 3)}
222+
"""
223+
else
224+
# some people have weird docs that are not valid UTF-8
225+
Logger.warning("Invalid docs for hover: #{inspect(docs)}")
226+
""
227+
end
222228
end
223229

224230
defp format_header(text) do

0 commit comments

Comments
 (0)