Removed Map.reject call, fixed compile warnings

Author: scohen

apps/language_server/lib/language_server/experimental/protocol/proto/macros/parse.ex

@@ -71,7 +71,9 @@ defmodule ElixirLS.LanguageServer.Experimental.Protocol.Proto.Macros.Parse do
              Field.extract(
                unquote(splat_opt),
                :..,
-               Map.reject(unquote(map_parameter_var), fn {k, _} -> k in unquote(known_keys) end)
+               unquote(map_parameter_var)
+               |> Enum.reject(fn {k, _} -> k in unquote(known_keys) end)
+               |> Map.new()
              )}
           end
 

apps/language_server/lib/language_server/experimental/source_file/conversions.ex

@@ -48,10 +48,6 @@ defmodule ElixirLS.LanguageServer.Experimental.SourceFile.Conversions do
     position
   end
 
-  def to_elixir(%LSPosition{} = position, %SourceFile{} = source_file) do
-    to_elixir(position, source_file.document)
-  end
-
   def to_elixir(%LSPosition{} = position, %Document{} = document) do
     document_size = Document.size(document)
     # we need to handle out of bounds line numbers, because it's possible to build a document

apps/language_server/test/experimental/server/state_test.exs

@@ -78,7 +78,7 @@ defmodule ElixirLS.LanguageServer.Experimental.Server.StateTest do
     setup [:with_an_open_document]
 
     test "can be changed", %{state: state} do
-      assert {:ok, state} = State.apply(state, change_notification())
+      assert {:ok, _state} = State.apply(state, change_notification())
 
       assert {:ok, file} = SourceFile.Store.fetch(uri())
       assert file.dirty?
@@ -98,7 +98,7 @@ defmodule ElixirLS.LanguageServer.Experimental.Server.StateTest do
     test "should clear the dirty field when saved", ctx do
       assert {:ok, save} = build(Notifications.DidSave, text_document: [uri: uri()])
       assert {:ok, %{dirty?: true}} = SourceFile.Store.fetch(uri())
-      assert {:ok, state} = State.apply(ctx.state, save)
+      assert {:ok, _state} = State.apply(ctx.state, save)
 
       assert {:ok, %{dirty?: false}} = SourceFile.Store.fetch(uri())
     end

apps/language_server/test/experimental/source_file_test.exs

@@ -5,10 +5,7 @@ defmodule ElixirLS.LanguageServer.Experimental.SourceFileTest do
   use Patch
 
   alias ElixirLS.LanguageServer.Experimental
-  alias ElixirLS.LanguageServer.Experimental.SourceFile.Conversions
   alias ElixirLS.LanguageServer.SourceFile
-
-  import ExUnit.CaptureIO
   import ElixirLS.LanguageServer.Experimental.SourceFile, except: [to_string: 1]
 
   def text(%Experimental.SourceFile{} = source) do