fix references crash on nil column

Author: lukaszsamson

apps/language_server/lib/language_server/providers/code_action/replace_remote_function.ex

@@ -157,6 +157,7 @@ defmodule ElixirLS.LanguageServer.Providers.CodeAction.ReplaceRemoteFunction do
 
   @spec expand_alias(SourceFile.t(), [atom()], non_neg_integer()) :: {:ok, atom()} | :error
   defp expand_alias(source_file, module_alias, line_number) do
+    # TODO use Macro.Env
     with {:ok, aliases} <- aliases_at(source_file, line_number) do
       aliases
       |> Enum.map(fn {module, aliased} ->

apps/language_server/lib/language_server/providers/completion/reducers/struct.ex

@@ -83,6 +83,7 @@ defmodule ElixirLS.LanguageServer.Providers.Completion.Reducers.Struct do
           case {type, elixir_prefix} do
             {{:atom, mod}, false} ->
               # which_struct returns not expanded aliases
+              # TODO use Macro.Env
               {:atom, Introspection.expand_alias(mod, aliases)}
 
             _ ->

apps/language_server/lib/language_server/providers/completion/reducers/type_specs.ex

@@ -69,6 +69,7 @@ defmodule ElixirLS.LanguageServer.Providers.Completion.Reducers.TypeSpecs do
 
   defp expand({{:attribute, _} = type, hint}, env, aliases) do
     # TODO Binding should return expanded aliases
+    # TODO use Macro.Env
     case Binding.expand(env, type) do
       {:atom, module} -> {Introspection.expand_alias(module, aliases), hint}
       _ -> {nil, ""}
@@ -77,6 +78,7 @@ defmodule ElixirLS.LanguageServer.Providers.Completion.Reducers.TypeSpecs do
 
   defp expand({{:variable, _, _} = type, hint}, env, aliases) do
     # TODO Binding should return expanded aliases
+    # TODO use Macro.Env
     case Binding.expand(env, type) do
       {:atom, module} -> {Introspection.expand_alias(module, aliases), hint}
       _ -> {nil, ""}

apps/language_server/lib/language_server/providers/hover/docs.ex

@@ -657,6 +657,7 @@ defmodule ElixirLS.LanguageServer.Providers.Hover.Docs do
   end
 
   def expand({{:atom, module}, func}, aliases) do
+    # TODO use Macro.Env
     {Introspection.expand_alias(module, aliases), func}
   end
 

apps/language_server/lib/language_server/providers/implementation/locator.ex

@@ -77,6 +77,7 @@ defmodule ElixirLS.LanguageServer.Providers.Implementation.Locator do
         module =
           case Binding.expand(binding_env, module_type) do
             {:atom, module} ->
+              # TODO use Macro.Env
               Introspection.expand_alias(module, env.aliases)
 
             _ ->

apps/language_server/lib/language_server/providers/references/locator.ex

@@ -269,7 +269,7 @@ defmodule ElixirLS.LanguageServer.Providers.References.Locator do
       uri: nil,
       range: %{
         start: %{line: line, column: column},
-        end: %{line: line, column: column + String.length(subject)}
+        end: %{line: line, column: if(column != nil, do: column + String.length(subject))}
       }
     }
   end
@@ -279,6 +279,7 @@ defmodule ElixirLS.LanguageServer.Providers.References.Locator do
 
   defp expand({type, func}, env, _module, aliases) do
     case Binding.expand(env, type) do
+      # TODO use Macro.Env
       {:atom, module} -> {Introspection.expand_alias(module, aliases), func}
       _ -> {nil, nil}
     end