Skip to content

Commit bfd0694

Browse files
committed
improve version checks
1 parent 58317a5 commit bfd0694

File tree

6 files changed

+8
-8
lines changed

6 files changed

+8
-8
lines changed

apps/elixir_ls_utils/test/complete_test.exs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1029,7 +1029,7 @@ defmodule ElixirLS.Utils.CompletionEngineTest do
10291029

10301030
# local call on var
10311031

1032-
if Version.match?(System.version(), "< 1.16.0-dev") do
1032+
if Version.match?(System.version(), "< 1.16.0") do
10331033
assert [] == expand(~c"asd.(")
10341034
assert [] == expand(~c"@asd.(")
10351035
else

apps/language_server/lib/language_server/providers/plugins/phoenix.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ defmodule ElixirLS.LanguageServer.Plugins.Phoenix do
2424
ModuleStore.ensure_compiled(context, Phoenix.Router)
2525
end
2626

27-
if Version.match?(System.version(), ">= 1.14.0") do
27+
if Version.match?(System.version(), ">= 1.14.0-dev") do
2828
@impl true
2929
def suggestions(hint, {Phoenix.Router, func, 1, _info}, _list, opts)
3030
when func in @phoenix_route_funcs do

apps/language_server/test/diagnostics_test.exs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ defmodule ElixirLS.LanguageServer.DiagnosticsTest do
22
alias ElixirLS.LanguageServer.Diagnostics
33
use ExUnit.Case
44

5-
if Version.match?(System.version(), "< 1.16.0-dev") do
5+
if Version.match?(System.version(), "< 1.16.0") do
66
describe "pre 1.16 Mix.Task.Compiler.Diagnostic normalization" do
77
test "extract the stacktrace from the message and format it" do
88
root_path = Path.join(__DIR__, "fixtures/build_errors")

apps/language_server/test/providers/references/locator_test.exs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ defmodule ElixirLS.LanguageServer.Providers.References.LocatorTest do
411411
}
412412
] = references
413413

414-
if Version.match?(System.version(), ">= 1.14.0-rc.0") do
414+
if Version.match?(System.version(), ">= 1.14.0") do
415415
# before 1.14 tracer reports invalid positions for captures
416416
# https://github.com/elixir-lang/elixir/issues/12023
417417
assert range == %{start: %{line: 55, column: 72}, end: %{line: 55, column: 83}}

apps/language_server/test/providers/selection_ranges_test.exs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ defmodule ElixirLS.LanguageServer.Providers.SelectionRangesTest do
228228
assert_range(ranges, range(1, 0, 2, 4))
229229
end
230230

231-
if Version.match?(System.version(), ">= 1.14.0-dev") do
231+
if Version.match?(System.version(), ">= 1.14.0") do
232232
test "left from do" do
233233
text = """
234234
do
@@ -262,7 +262,7 @@ defmodule ElixirLS.LanguageServer.Providers.SelectionRangesTest do
262262
assert_range(ranges, range(0, 0, 3, 3))
263263
end
264264

265-
if Version.match?(System.version(), ">= 1.14.0-dev") do
265+
if Version.match?(System.version(), ">= 1.14.0") do
266266
test "left from end" do
267267
text = """
268268
do
@@ -1030,7 +1030,7 @@ defmodule ElixirLS.LanguageServer.Providers.SelectionRangesTest do
10301030
assert_range(ranges, range(0, 8, 0, 12))
10311031
end
10321032

1033-
if Version.match?(System.version(), ">= 1.14.0-dev") do
1033+
if Version.match?(System.version(), ">= 1.14.0") do
10341034
test "left side of | near" do
10351035
text = """
10361036
%{state | 1 => 1, counter: counter + to_dispatch, demand: demand - to_dispatch}

apps/language_server/test/support/server_test_helpers.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ defmodule ElixirLS.LanguageServer.Test.ServerTestHelpers do
2727
def replace_logger(packet_capture) do
2828
# :logger application is already started
2929
# replace console logger with LSP
30-
if Version.match?(System.version(), ">= 1.15.0-dev") do
30+
if Version.match?(System.version(), ">= 1.15.0") do
3131
configs =
3232
for handler_id <- :logger.get_handler_ids() do
3333
{:ok, config} = :logger.get_handler_config(handler_id)

0 commit comments

Comments
 (0)