Elixir 1.11 support (#360)

* silence warning

* silence warning

* handle eex compiler returning error colum

* update elixir_sense

* fix warning

the test was incomplete

* capture log

* fix mixfile purging in in_fixture

Author: lukaszsamson

apps/elixir_ls_debugger/test/debugger_test.exs

@@ -192,6 +192,7 @@ defmodule ElixirLS.Debugger.ServerTest do
       assert Process.alive?(server)
     end
 
+    @tag :capture_log
     test "Evaluate expression with ERROR result", %{server: server} do
       Server.receive_packet(
         server,

apps/elixir_ls_utils/mix.exs

@@ -15,7 +15,8 @@ defmodule ElixirLS.Utils.Mixfile do
       start_permanent: false,
       build_per_environment: false,
       consolidate_protocols: false,
-      deps: deps()
+      deps: deps(),
+      xref: [exclude: [JasonVendored, Logger]]
     ]
   end
 

apps/elixir_ls_utils/test/support/mix_test.case.ex

@@ -80,9 +80,10 @@ defmodule ElixirLS.Utils.MixTest.Case do
       :code.set_path(get_path)
 
       for {mod, file} <- :code.all_loaded() -- previous,
-          file == :in_memory or (is_list(file) and :lists.prefix(flag, file)) do
-        purge([mod])
+          file == :in_memory or file == [] or (is_list(file) and :lists.prefix(flag, file)) do
+        mod
       end
+      |> purge
 
       restore_project_stack!(project_stack)
     end

apps/language_server/lib/language_server/diagnostics.ex

@@ -93,7 +93,7 @@ defmodule ElixirLS.LanguageServer.Diagnostics do
   end
 
   defp split_file_and_description(message, root_path) do
-    with [_, file, line, description] <- Regex.run(~r/^(.*?):(\d+): (.*)/s, message),
+    with {file, line, _column, description} <- get_message_parts(message),
          {:ok, path} <- file_path(file, root_path) do
       {path, String.to_integer(line), description}
     else
@@ -102,6 +102,15 @@ defmodule ElixirLS.LanguageServer.Diagnostics do
     end
   end
 
+  defp get_message_parts(message) do
+    # since elixir 1.11 eex compiler returns line and column on error
+    case Regex.run(~r/^(.*?):(\d+)(:(\d+))?: (.*)/s, message) do
+      [_, file, line, description] -> {file, line, 0, description}
+      [_, file, line, _, column, description] -> {file, line, column, description}
+      _ -> nil
+    end
+  end
+
   defp file_path(file, root_path) do
     path = Path.join([root_path, file])
 

apps/language_server/test/providers/document_symbols_test.exs

@@ -2426,8 +2426,18 @@ defmodule ElixirLS.LanguageServer.Providers.DocumentSymbolsTest do
     end
     """
 
-    assert {:ok, document_symbols} = DocumentSymbols.symbols(uri, text, true)
-    # IO.inspect(document_symbols, label: "document_symbols")
-    # assert String.contains?(message, "Compilation error")
+    assert {:ok,
+            [
+              %Protocol.DocumentSymbol{
+                children: [
+                  %Protocol.DocumentSymbol{
+                    name: "def hello"
+                  },
+                  %Protocol.DocumentSymbol{
+                    name: "defp greetings"
+                  }
+                ]
+              }
+            ]} = DocumentSymbols.symbols(uri, text, true)
   end
 end

mix.lock

@@ -1,7 +1,7 @@
 %{
   "dialyxir": {:hex, :dialyxir, "1.0.0", "6a1fa629f7881a9f5aaf3a78f094b2a51a0357c843871b8bc98824e7342d00a5", [:mix], [{:erlex, ">= 0.2.6", [hex: :erlex, repo: "hexpm", optional: false]}], "hexpm", "aeb06588145fac14ca08d8061a142d52753dbc2cf7f0d00fc1013f53f8654654"},
   "docsh": {:hex, :docsh, "0.7.2", "f893d5317a0e14269dd7fe79cf95fb6b9ba23513da0480ec6e77c73221cae4f2", [:rebar3], [{:providers, "1.8.1", [hex: :providers, repo: "hexpm", optional: false]}], "hexpm", "4e7db461bb07540d2bc3d366b8513f0197712d0495bb85744f367d3815076134"},
-  "elixir_sense": {:git, "https://github.com/elixir-lsp/elixir_sense.git", "8c82bc726f6f0e33680287ead72390fe4a8a74dd", []},
+  "elixir_sense": {:git, "https://github.com/elixir-lsp/elixir_sense.git", "5a37db1bcc4b6d1cbc3dbbc669902af85b5d29ec", []},
   "erl2ex": {:git, "https://github.com/dazuma/erl2ex.git", "244c2d9ed5805ef4855a491d8616b8842fef7ca4", []},
   "erlex": {:hex, :erlex, "0.2.6", "c7987d15e899c7a2f34f5420d2a2ea0d659682c06ac607572df55a43753aa12e", [:mix], [], "hexpm", "2ed2e25711feb44d52b17d2780eabf998452f6efda104877a3881c2f8c0c0c75"},
   "forms": {:hex, :forms, "0.0.1", "45f3b10b6f859f95f2c2c1a1de244d63855296d55ed8e93eb0dd116b3e86c4a6", [:rebar3], [], "hexpm", "530f63ed8ed5a171f744fc75bd69cb2e36496899d19dbef48101b4636b795868"},