Merge pull request #1130 from sabiwara/require-defmacro

Avoid requiring the module when using local macros

Author: lukaszsamson

apps/elixir_ls_utils/lib/completion_engine.ex

@@ -1028,7 +1028,7 @@ defmodule ElixirLS.Utils.CompletionEngine do
       needed_requires =
         for func_kind <- func_kinds do
           if func_kind in [:macro, :defmacro, :defguard] and mod not in env.requires and
-               mod != Kernel.SpecialForms do
+               mod != Kernel.SpecialForms and mod != env.module do
             mod
           end
         end

apps/elixir_ls_utils/test/complete_test.exs

@@ -2208,6 +2208,32 @@ defmodule ElixirLS.Utils.CompletionEngineTest do
            ] = expand(~c"unquote", %Env{requires: []})
   end
 
+
+  test "macros from the same module should not add needed_require" do
+    macro_info = %ElixirSense.Core.State.ModFunInfo{
+      type: :defmacro,
+      params: [[:_]]
+    }
+
+    metadata = %Metadata{
+      mods_funs_to_positions: %{
+        {MyModule, nil, nil} => %ElixirSense.Core.State.ModFunInfo{},
+        {MyModule, :info, 1} => macro_info
+      }
+    }
+
+    assert [
+             %{
+               name: "info",
+               arity: 1,
+               type: :macro,
+               origin: "MyModule",
+               needed_require: nil,
+               visibility: :public
+             }
+           ] = expand(~c"inf", %Env{requires: [], module: MyModule}, metadata)
+  end
+
   if Version.match?(System.version(), ">= 1.14.0") do
     test "Application.compile_env classified as macro" do
       assert [