add guards

Author: lukaszsamson

apps/language_server/lib/language_server/diagnostics.ex

@@ -222,7 +222,7 @@ defmodule ElixirLS.LanguageServer.Diagnostics do
     JsonRpc.notify("textDocument/publishDiagnostics", message)
   end
 
-  def mixfile_diagnostic({file, line, message}, severity) do
+  def mixfile_diagnostic({file, line, message}, severity) when not is_nil(file) do
     %Mix.Task.Compiler.Diagnostic{
       compiler_name: "ElixirLS",
       file: file,
@@ -237,7 +237,8 @@ defmodule ElixirLS.LanguageServer.Diagnostics do
         severity: severity,
         message: message,
         position: position
-      }) do
+      })
+      when not is_nil(file) do
     %Mix.Task.Compiler.Diagnostic{
       compiler_name: "ElixirLS",
       file: file,
@@ -247,7 +248,7 @@ defmodule ElixirLS.LanguageServer.Diagnostics do
     }
   end
 
-  def error_to_diagnostic(kind, payload, stacktrace, path, project_dir) do
+  def error_to_diagnostic(kind, payload, stacktrace, path, project_dir) when not is_nil(path) do
     path = SourceFile.Path.absname(path, project_dir)
     message = Exception.format(kind, payload, stacktrace)
 
@@ -261,15 +262,15 @@ defmodule ElixirLS.LanguageServer.Diagnostics do
 
     %Mix.Task.Compiler.Diagnostic{
       compiler_name: "ElixirLS",
-      file: SourceFile.Path.absname(path, project_dir),
+      file: path,
       position: line || 0,
       message: message,
       severity: :error,
       details: payload
     }
   end
 
-  def exception_to_diagnostic(error, path) do
+  def exception_to_diagnostic(error, path) when not is_nil(path) do
     msg =
       case error do
         {:shutdown, 1} ->

apps/language_server/lib/language_server/source_file/path.ex

@@ -41,7 +41,7 @@ defmodule ElixirLS.LanguageServer.SourceFile.Path do
     uri |> from_uri |> absname()
   end
 
-  def absolute_from_uri(uri, project_dir) do
+  def absolute_from_uri(uri, project_dir) when is_binary(project_dir) or is_nil(project_dir) do
     if project_dir == nil do
       uri |> from_uri |> absname()
     else
@@ -57,7 +57,7 @@ defmodule ElixirLS.LanguageServer.SourceFile.Path do
     path |> expand(project_dir) |> convert_separators_to_native()
   end
 
-  def to_uri(path) do
+  def to_uri(path) when is_binary(path) do
     path =
       path
       |> expand()
@@ -66,7 +66,8 @@ defmodule ElixirLS.LanguageServer.SourceFile.Path do
     to_uri_impl(path)
   end
 
-  def to_uri(path, project_dir) do
+  def to_uri(path, project_dir)
+      when is_binary(path) and (is_binary(project_dir) or is_nil(project_dir)) do
     path =
       if project_dir == nil do
         expand(path)