Skip to content

Commit 94bda2d

Browse files
committed
exclude more version dependant tests
1 parent b7392be commit 94bda2d

File tree

1 file changed

+45
-33
lines changed

1 file changed

+45
-33
lines changed

apps/language_server/test/providers/code_action/replace_remote_function_test.exs

Lines changed: 45 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,10 @@ defmodule ElixirLS.LanguageServer.Providers.CodeAction.ReplaceRemoteFunctionTest
125125
}
126126
|> modify(suggestion: "Enum.concat")
127127

128-
assert result ==
129-
"for x <- Enum.concat([[1], [2], [3]]), do: Enum.concat([[1], [2], [3], [x]])"
128+
if Version.match?(System.version(), ">= 1.13.0") do
129+
assert result ==
130+
"for x <- Enum.concat([[1], [2], [3]]), do: Enum.concat([[1], [2], [3], [x]])"
131+
end
130132
end
131133

132134
test "applied in a with block" do
@@ -136,7 +138,9 @@ defmodule ElixirLS.LanguageServer.Providers.CodeAction.ReplaceRemoteFunctionTest
136138
}
137139
|> modify()
138140

139-
assert result == "with x <- Enum.count([1, 2, 3]), do: x"
141+
if Version.match?(System.version(), ">= 1.13.0") do
142+
assert result == "with x <- Enum.count([1, 2, 3]), do: x"
143+
end
140144
end
141145

142146
test "applied in a with block, preserves comment" do
@@ -146,7 +150,9 @@ defmodule ElixirLS.LanguageServer.Providers.CodeAction.ReplaceRemoteFunctionTest
146150
}
147151
|> modify()
148152

149-
assert result == "with x <- Enum.count([1, 2, 3]), do: x # TODO: Fix this"
153+
if Version.match?(System.version(), ">= 1.13.0") do
154+
assert result == "with x <- Enum.count([1, 2, 3]), do: x # TODO: Fix this"
155+
end
150156
end
151157

152158
test "applied in a with block with started do end" do
@@ -156,7 +162,9 @@ defmodule ElixirLS.LanguageServer.Providers.CodeAction.ReplaceRemoteFunctionTest
156162
}
157163
|> modify()
158164

159-
assert result == "with x <- Enum.count([1, 2, 3]) do"
165+
if Version.match?(System.version(), ">= 1.13.0") do
166+
assert result == "with x <- Enum.count([1, 2, 3]) do"
167+
end
160168
end
161169

162170
test "preserving the leading indent" do
@@ -165,20 +173,22 @@ defmodule ElixirLS.LanguageServer.Providers.CodeAction.ReplaceRemoteFunctionTest
165173
assert result == " Enum.count([1, 2, 3])"
166174
end
167175

168-
test "handles erlang functions" do
169-
message = """
170-
:ets.inserd/2 is undefined or private. Did you mean:
171-
* insert/2
172-
* insert_new/2
173-
"""
174-
175-
{:ok, [result]} =
176-
~q{
177-
:ets.inserd(a, b)
178-
}
179-
|> modify(message: message, suggestion: ":ets.insert(a, b)")
180-
181-
assert result == ":ets.insert(a, b)"
176+
if System.otp_release() |> String.to_integer() >= 23 do
177+
test "handles erlang functions" do
178+
message = """
179+
:ets.inserd/2 is undefined or private. Did you mean:
180+
* insert/2
181+
* insert_new/2
182+
"""
183+
184+
{:ok, [result]} =
185+
~q{
186+
:ets.inserd(a, b)
187+
}
188+
|> modify(message: message, suggestion: ":ets.insert(a, b)")
189+
190+
assert result == ":ets.insert(a, b)"
191+
end
182192
end
183193

184194
test "when aliased" do
@@ -293,20 +303,22 @@ defmodule ElixirLS.LanguageServer.Providers.CodeAction.ReplaceRemoteFunctionTest
293303
assert result == " &Enum.count/1"
294304
end
295305

296-
test "handles erlang functions" do
297-
message = """
298-
:ets.inserd/2 is undefined or private. Did you mean:
299-
* insert/2
300-
* insert_new/2
301-
"""
302-
303-
{:ok, [result]} =
304-
~q{
305-
&:ets.inserd/2
306-
}
307-
|> modify(message: message, suggestion: ":ets.insert/2")
308-
309-
assert result == "&:ets.insert/2"
306+
if System.otp_release() |> String.to_integer() >= 23 do
307+
test "handles erlang functions" do
308+
message = """
309+
:ets.inserd/2 is undefined or private. Did you mean:
310+
* insert/2
311+
* insert_new/2
312+
"""
313+
314+
{:ok, [result]} =
315+
~q{
316+
&:ets.inserd/2
317+
}
318+
|> modify(message: message, suggestion: ":ets.insert/2")
319+
320+
assert result == "&:ets.insert/2"
321+
end
310322
end
311323

312324
test "when aliased" do

0 commit comments

Comments
 (0)