Fix awaiting_contracts not getting responses (#433)

* do not add amore awaiting contracts for the same uri

* there should not be any awaiting contracts for not open uris

* group by to avoid multiple filtering

Author: lukaszsamson

apps/language_server/lib/language_server/server.ex

@@ -124,7 +124,9 @@ defmodule ElixirLS.LanguageServer.Server do
         {:reply, Dialyzer.suggest_contracts([SourceFile.path_from_uri(uri)]), state}
 
       _ ->
-        {:noreply, %{state | awaiting_contracts: [{from, uri} | state.awaiting_contracts]}}
+        awaiting_contracts = reject_awaiting_contracts(state.awaiting_contracts, uri)
+
+        {:noreply, %{state | awaiting_contracts: [{from, uri} | awaiting_contracts]}}
     end
   end
 
@@ -339,11 +341,7 @@ defmodule ElixirLS.LanguageServer.Server do
 
       state
     else
-      awaiting_contracts =
-        Enum.reject(state.awaiting_contracts, fn
-          {from, ^uri} -> GenServer.reply(from, [])
-          _ -> false
-        end)
+      awaiting_contracts = reject_awaiting_contracts(state.awaiting_contracts, uri)
 
       %{
         state
@@ -876,24 +874,20 @@ defmodule ElixirLS.LanguageServer.Server do
 
       {dirty, not_dirty} =
         state.awaiting_contracts
-        |> Enum.filter(fn {_, uri} ->
-          state.source_files[uri] != nil
-        end)
         |> Enum.split_with(fn {_, uri} ->
           state.source_files[uri].dirty?
         end)
 
-      contracts =
+      contracts_by_file =
         not_dirty
-        |> Enum.uniq()
         |> Enum.map(fn {_from, uri} -> SourceFile.path_from_uri(uri) end)
         |> Dialyzer.suggest_contracts()
+        |> Enum.group_by(fn {file, _, _, _, _} -> file end)
 
       for {from, uri} <- not_dirty do
         contracts =
-          Enum.filter(contracts, fn {file, _, _, _, _} ->
-            SourceFile.path_from_uri(uri) == file
-          end)
+          contracts_by_file
+          |> Map.get(SourceFile.path_from_uri(uri), [])
 
         GenServer.reply(from, contracts)
       end
@@ -1087,4 +1081,11 @@ defmodule ElixirLS.LanguageServer.Server do
         source_file
     end
   end
+
+  defp reject_awaiting_contracts(awaiting_contracts, uri) do
+    Enum.reject(awaiting_contracts, fn
+      {from, ^uri} -> GenServer.reply(from, [])
+      _ -> false
+    end)
+  end
 end