Update version checks (#343)

* bump min elixir version in mix files and .tool-versions

* update otp and elixir version checks

* remove no longer needed elixir 1.7 workarounds

* remove elixir 1.10-rc support

* fix warnings

Author: lukaszsamson

.tool-versions

@@ -1,10 +1,10 @@
 # This file contains the recommended versions for developing and running
-# elixir-ls. However, elixir-ls supports a minumum version of Elixir 1.7.0 with
-# OTP 20 and should work with any later releases.
+# elixir-ls. However, elixir-ls supports a minumum version of Elixir 1.8.0 with
+# OTP 21 and should work with any later releases.
 # Using asdf to manage your elixir and OTP versions is not required, you can
 # use the system-installed version instead.
 #
 # The versions selected here are the versions that are used to build a binary
 # release for distribution
-elixir 1.7.4-otp-21
+elixir 1.8.2-otp-21
 erlang 21.3.8.17

apps/elixir_ls_debugger/lib/debugger/cli.ex

@@ -17,6 +17,13 @@ defmodule ElixirLS.Debugger.CLI do
   defp warn_if_unsupported_version do
     elixir_version = System.version()
 
+    unless Version.match?(elixir_version, ">= 1.8.0") do
+      message =
+        "WARNING: Elixir versions below 1.8 are not supported. (Currently v#{elixir_version})"
+
+      Output.print_err(message)
+    end
+
     if Version.match?(elixir_version, ">= 1.10.0") && Version.match?(elixir_version, "< 1.10.3") do
       message =
         "WARNING: Debugging is not supported on Elixir #{elixir_version}. Please upgrade" <>
@@ -25,5 +32,14 @@ defmodule ElixirLS.Debugger.CLI do
 
       Output.print_err(message)
     end
+
+    otp_release = String.to_integer(System.otp_release())
+
+    if otp_release < 21 do
+      message =
+        "WARNING: Erlang OTP releases below 21 are not supported (Currently OTP #{otp_release})"
+
+      Output.print_err(message)
+    end
   end
 end

apps/elixir_ls_debugger/lib/debugger/server.ex

@@ -130,7 +130,6 @@ defmodule ElixirLS.Debugger.Server do
   ## Helpers
 
   defp handle_request(initialize_req(_, client_info), state) do
-    check_erlang_version()
     {capabilities(), %{state | client_info: client_info}}
   end
 
@@ -607,17 +606,6 @@ defmodule ElixirLS.Debugger.Server do
       module not in exclude_modules
   end
 
-  defp check_erlang_version do
-    version = String.to_integer(to_string(:erlang.system_info(:otp_release)))
-
-    if version < 20 do
-      IO.warn(
-        "Erlang version >= OTP 20 is required to debug Elixir. " <>
-          "(Current version: #{version})\n"
-      )
-    end
-  end
-
   defp change_env(env) do
     Mix.env(env)
 

apps/elixir_ls_debugger/mix.exs

@@ -9,7 +9,7 @@ defmodule ElixirLS.Debugger.Mixfile do
       config_path: "../../config/config.exs",
       deps_path: "../../deps",
       lockfile: "../../mix.lock",
-      elixir: ">= 1.7.0",
+      elixir: ">= 1.8.0",
       build_embedded: false,
       start_permanent: true,
       build_per_environment: false,

apps/elixir_ls_utils/mix.exs

@@ -10,7 +10,7 @@ defmodule ElixirLS.Utils.Mixfile do
       deps_path: "../../deps",
       elixirc_paths: elixirc_paths(Mix.env()),
       lockfile: "../../mix.lock",
-      elixir: ">= 1.7.0",
+      elixir: ">= 1.8.0",
       build_embedded: false,
       start_permanent: false,
       build_per_environment: false,

apps/elixir_ls_utils/test/support/mix_test.case.ex

@@ -139,7 +139,7 @@ defmodule ElixirLS.Utils.MixTest.Case do
   # FIXME: Private API
   defp clear_mix_cache do
     module =
-      if Version.match?(System.version(), ">= 1.10.0-rc.0") do
+      if Version.match?(System.version(), ">= 1.10.0") do
         Mix.State
       else
         Mix.ProjectStack

apps/language_server/lib/language_server/build.ex

@@ -11,14 +11,7 @@ defmodule ElixirLS.LanguageServer.Build do
           {us, _} =
             :timer.tc(fn ->
               IO.puts("MIX_ENV: #{Mix.env()}")
-
-              if function_exported?(Mix, :target, 0) do
-                # Even though we know we have the function here,
-                # Compilation will fail calling Mix.target/0 directly
-                # since Elixir 1.7 is used to compile - So we get around
-                # that with apply/3
-                IO.puts("MIX_TARGET: #{apply(Mix, :target, [])}")
-              end
+              IO.puts("MIX_TARGET: #{Mix.target()}")
 
               prev_deps = cached_deps()
               :ok = Mix.Project.clear_deps_cache()

apps/language_server/lib/language_server/dialyzer.ex

@@ -25,35 +25,20 @@ defmodule ElixirLS.LanguageServer.Dialyzer do
   # Client API
 
   def check_support do
-    otp_release = String.to_integer(System.otp_release())
-    {compiled_with, _} = System.build_info() |> Map.fetch!(:otp_release) |> Integer.parse()
+    _otp_release = String.to_integer(System.otp_release())
+    {_compiled_with, _} = System.build_info() |> Map.fetch!(:otp_release) |> Integer.parse()
 
     cond do
-      otp_release < 20 ->
-        {:error,
-         "Dialyzer integration requires Erlang OTP 20 or higher (Currently OTP #{otp_release})"}
-
       not Code.ensure_loaded?(:dialyzer) ->
         {:error,
          "The current Erlang installation does not include Dialyzer. It may be available as a " <>
            "separate package."}
 
-      otp_release >= 21 and compiled_with < 20 ->
-        {:error,
-         "Dialyzer in Erlang/OTP versions >= 21 requires Elixir to have been compiled with an " <>
-           "Erlang/OTP version >= 20, but current Elixir was compiled with " <>
-           "version #{compiled_with}"}
-
       not dialyzable?(System) ->
         {:error,
          "Dialyzer is disabled because core Elixir modules are missing debug info. " <>
            "You may need to recompile Elixir with Erlang >= OTP 20"}
 
-      Version.match?(System.version(), "1.7.0") ->
-        {:error,
-         "Dialyzer is disabled in Elixir v1.7.0 due to a bug in Dialyzer. " <>
-           "Upgrade Elixir to >= v1.7.1 to enable"}
-
       true ->
         :ok
     end

apps/language_server/lib/language_server/server.ex

@@ -723,19 +723,19 @@ defmodule ElixirLS.LanguageServer.Server do
   end
 
   defp show_version_warnings do
-    unless Version.match?(System.version(), ">= 1.7.0") do
+    unless Version.match?(System.version(), ">= 1.8.0") do
       JsonRpc.show_message(
         :warning,
-        "Elixir versions below 1.7 are not supported. (Currently v#{System.version()})"
+        "Elixir versions below 1.8 are not supported. (Currently v#{System.version()})"
       )
     end
 
     otp_release = String.to_integer(System.otp_release())
 
-    if otp_release < 20 do
+    if otp_release < 21 do
       JsonRpc.show_message(
         :info,
-        "Erlang OTP releases below 20 are not supported (Currently OTP #{otp_release})"
+        "Erlang OTP releases below 21 are not supported (Currently OTP #{otp_release})"
       )
     end
 
@@ -796,16 +796,7 @@ defmodule ElixirLS.LanguageServer.Server do
   defp maybe_set_mix_target(state, nil), do: state
 
   defp maybe_set_mix_target(state, target) do
-    if Version.match?(System.version(), ">= 1.8.0") do
-      set_mix_target(state, target)
-    else
-      JsonRpc.show_message(
-        :warning,
-        "MIX_TARGET was set, but it requires Elixir >= 1.8.0. This setting will be ignored"
-      )
-
-      state
-    end
+    set_mix_target(state, target)
   end
 
   defp set_mix_target(state, target) do
@@ -814,10 +805,7 @@ defmodule ElixirLS.LanguageServer.Server do
     prev_target = state.settings["mixTarget"]
 
     if is_nil(prev_target) or target == prev_target do
-      # We've already checked for Elixir >= 1.8.0 by this point
-      # but compilation will fail if we just call Mix.target/0
-      # so we get around that via apply/3
-      apply(Mix, :target, [String.to_atom(target)])
+      Mix.target(String.to_atom(target))
     else
       JsonRpc.show_message(:warning, "You must restart ElixirLS after changing Mix target")
     end

apps/language_server/mix.exs

@@ -5,7 +5,7 @@ defmodule ElixirLS.LanguageServer.Mixfile do
     [
       app: :language_server,
       version: "0.5.0",
-      elixir: ">= 1.7.0",
+      elixir: ">= 1.8.0",
       build_path: "../../_build",
       config_path: "../../config/config.exs",
       deps_path: "../../deps",