Rename the test file and move the duplicated logic to code_mod folder

Author: scottming

apps/language_server/lib/language_server/experimental/code_mod/location.ex

@@ -0,0 +1,28 @@
+defmodule ElixirLS.LanguageServer.Experimental.CodeMod.Location do
+  @moduledoc """
+  A module that converts ElixirSense location to LSP location.
+  """
+  alias ElixirLS.LanguageServer.Experimental.Protocol.Types.Location, as: LSLocation
+  alias ElixirLS.LanguageServer.Experimental.Protocol.Types.Range, as: LSRange
+  alias ElixirLS.LanguageServer.Experimental.SourceFile
+  alias ElixirLS.LanguageServer.Experimental.SourceFile.Conversions
+
+  def to_lsp(%{line: line, column: column} = elixir_sense_definition, current_source_file) do
+    {:ok, current_source_file}
+    position = SourceFile.Position.new(line, column - 1)
+
+    with {:ok, source_file} <- fetch_source_file(elixir_sense_definition, current_source_file),
+         {:ok, ls_position} <- Conversions.to_lsp(position, source_file) do
+      ls_range = %LSRange{start: ls_position, end: ls_position}
+      {:ok, LSLocation.new(uri: source_file.uri, range: ls_range)}
+    end
+  end
+
+  defp fetch_source_file(%{file: nil}, current_source_file) do
+    {:ok, current_source_file}
+  end
+
+  defp fetch_source_file(%{file: path}, _) do
+    SourceFile.Store.open_temporary(path)
+  end
+end

apps/language_server/lib/language_server/experimental/provider/handlers/goto_definition.ex

@@ -1,10 +1,8 @@
 defmodule ElixirLS.LanguageServer.Experimental.Provider.Handlers.GotoDefinition do
   alias ElixirLS.LanguageServer.Experimental.Protocol.Requests.GotoDefinition
   alias ElixirLS.LanguageServer.Experimental.Protocol.Responses
-  alias ElixirLS.LanguageServer.Experimental.Protocol.Types.Location
-  alias ElixirLS.LanguageServer.Experimental.Protocol.Types.Range, as: LSRange
+  alias ElixirLS.LanguageServer.Experimental.CodeMod.Location, as: CodeModLocation
   alias ElixirLS.LanguageServer.Experimental.SourceFile
-  alias ElixirLS.LanguageServer.Experimental.SourceFile.Conversions
   require Logger
 
   def handle(%GotoDefinition{} = request, _) do
@@ -15,7 +13,7 @@ defmodule ElixirLS.LanguageServer.Experimental.Provider.Handlers.GotoDefinition
 
     with %ElixirSense.Location{} = location <-
            ElixirSense.definition(source_file_string, pos.line, pos.character + 1),
-         {:ok, definition} <- build_definition(location, source_file) do
+         {:ok, definition} <- CodeModLocation.to_lsp(location, source_file) do
       {:reply, Responses.GotoDefinition.new(request.id, definition)}
     else
       nil ->
@@ -26,25 +24,4 @@ defmodule ElixirLS.LanguageServer.Experimental.Provider.Handlers.GotoDefinition
         {:error, Responses.GotoDefinition.error(request.id, :request_failed, reason)}
     end
   end
-
-  defp build_definition(
-         %{line: line, column: column} = elixir_sense_definition,
-         current_source_file
-       ) do
-    position = SourceFile.Position.new(line, column - 1)
-
-    with {:ok, source_file} <- get_source_file(elixir_sense_definition, current_source_file),
-         {:ok, ls_position} <- Conversions.to_lsp(position, source_file) do
-      ls_range = %LSRange{start: ls_position, end: ls_position}
-      {:ok, Location.new(uri: source_file.uri, range: ls_range)}
-    end
-  end
-
-  defp get_source_file(%{file: nil}, current_source_file) do
-    {:ok, current_source_file}
-  end
-
-  defp get_source_file(%{file: path}, _) do
-    SourceFile.Store.open_temporary(path)
-  end
 end

apps/language_server/test/language_server/experimental/provider/handlers/goto_definition_test.exs renamed to apps/language_server/test/experimental/provider/handlers/goto_definition_test.exs

@@ -1,4 +1,4 @@
-defmodule ElixirLS.LanguageServer.Experimental.Provider.Handlers.GotoDefinitionTest do
+defmodule ElixirLS.Experimental.Provider.Handlers.GotoDefinitionTest do
   use ExUnit.Case, async: true
 
   alias ElixirLS.LanguageServer.Experimental.Protocol.Requests.GotoDefinition