resolve some TODOs

Author: lukaszsamson

apps/language_server/lib/language_server/markdown_utils.ex

@@ -151,7 +151,6 @@ defmodule ElixirLS.LanguageServer.MarkdownUtils do
   of ExDoc autolinker https://hexdocs.pm/ex_doc/readme.html#auto-linking
   """
   def transform_ex_doc_links(string, current_module \\ nil) do
-    # TODO add support for OTP 27
     string
     |> String.split(~r/(`.*?`)|(\[.*?\]\(.*?\))/u, include_captures: true)
     |> Enum.map(fn segment ->

apps/language_server/lib/language_server/mix_tasks/format.ex

@@ -371,7 +371,6 @@ defmodule Mix.Tasks.ElixirLSFormat do
   @doc """
   Returns formatter options to be used for the given file.
   """
-  # TODO: Deprecate on Elixir v1.17
   @doc deprecated: "Use formatter_for_file/2 instead"
   def formatter_opts_for_file(file, opts \\ []) do
     {_, formatter_opts} = formatter_for_file(file, opts)

apps/language_server/lib/language_server/providers/completion/suggestion.ex

@@ -126,15 +126,7 @@ defmodule ElixirLS.LanguageServer.Providers.Completion.Suggestion do
         {line, column}
       )
 
-    # TODO test surround_context
-    # surround = case NormalizedCode.Fragment.surround_context(code, {line, column}) do
-    #   :none ->
-    #     nil
-
-    #   context ->
-    #     {context.begin, context.end}
-    #   end
-
+    # This works better than Code.Fragment.surround_context
     surround =
       case {prefix, suffix} do
         {"", ""} ->

apps/language_server/lib/language_server/providers/execute_command/expand_macro.ex

@@ -20,7 +20,6 @@ defmodule ElixirLS.LanguageServer.Providers.ExecuteCommand.ExpandMacro do
     path = get_path(uri)
     cur_text = source_file.text
 
-    # TODO change/move this
     if String.trim(text) != "" do
       formatted =
         expand_full(cur_text, text, path, line + 1)

apps/language_server/test/providers/completion_test.exs

@@ -1448,32 +1448,34 @@ defmodule ElixirLS.LanguageServer.Providers.CompletionTest do
              } = first
     end
 
-    test "will suggest remote quoted calls" do
-      text = """
-      alias ElixirLS.LanguageServer.Fixtures.ExampleQuotedDefs, as: Quoted
-      Quoted.
-      #      ^
-      """
+    if Version.match?(System.version(), ">= 1.15.0") do
+      test "will suggest remote quoted calls" do
+        text = """
+        alias ElixirLS.LanguageServer.Fixtures.ExampleQuotedDefs, as: Quoted
+        Quoted.
+        #      ^
+        """
 
-      {line, char} = {1, 7}
+        {line, char} = {1, 7}
 
-      TestUtils.assert_has_cursor_char(text, line, char)
-      {line, char} = SourceFile.lsp_position_to_elixir(text, {line, char})
-      parser_context = ParserContextBuilder.from_string(text, {line, char})
+        TestUtils.assert_has_cursor_char(text, line, char)
+        {line, char} = SourceFile.lsp_position_to_elixir(text, {line, char})
+        parser_context = ParserContextBuilder.from_string(text, {line, char})
 
-      assert {:ok, %{"items" => items}} =
-               Completion.completion(
-                 parser_context,
-                 line,
-                 char,
-                 @supports
-               )
+        assert {:ok, %{"items" => items}} =
+                 Completion.completion(
+                   parser_context,
+                   line,
+                   char,
+                   @supports
+                 )
 
-      assert item = Enum.find(items, fn item -> item["label"] == "\"0abc\\\"asd\"" end)
-      assert item["insertText"] == "\"0abc\\\"asd\"($1)$0"
+        assert item = Enum.find(items, fn item -> item["label"] == "\"0abc\\\"asd\"" end)
+        assert item["insertText"] == "\"0abc\\\"asd\"($1)$0"
 
-      assert item["labelDetails"]["description"] ==
-               "ElixirLS.LanguageServer.Fixtures.ExampleQuotedDefs.\"0abc\\\"asd\"/2"
+        assert item["labelDetails"]["description"] ==
+                 "ElixirLS.LanguageServer.Fixtures.ExampleQuotedDefs.\"0abc\\\"asd\"/2"
+      end
     end
   end
 

apps/language_server/test/providers/definition/locator_test.exs

@@ -41,7 +41,6 @@ defmodule ElixirLS.LanguageServer.Providers.Definition.LocatorTest do
   end
 
   test "find definition of aliased modules in `use`" do
-    # TODO this test fails if there's no newline between alias and use
     buffer = """
     defmodule MyModule do
       alias ElixirSenseExample.UseExample
@@ -1060,7 +1059,7 @@ defmodule ElixirLS.LanguageServer.Providers.Definition.LocatorTest do
            }
   end
 
-  # TODO not supported in Code.Fragment.surround_context
+  # TODO not supported in Code.Fragment.surround_context as of elixir 1.17
   # test "find definition of &1 capture variable" do
   #   buffer = """
   #   defmodule MyModule do
@@ -1202,7 +1201,7 @@ defmodule ElixirLS.LanguageServer.Providers.Definition.LocatorTest do
            }
 
     # `a` redefined in a case clause
-    # TODO cursor lands in the wrong clause
+    # TODO cursor lands in the wrong clause on 1.17
     # defmodule MyModule do
     #   def my_fun(a, b) do
     #     case a do

apps/language_server/test/providers/references/locator_test.exs

@@ -243,7 +243,7 @@ defmodule ElixirLS.LanguageServer.Providers.References.LocatorTest do
              %{start: %{line: 65, column: 79}, end: %{line: 65, column: 83}} |> maybe_shift
   end
 
-  # TODO crashes metadata builder
+  # TODO attributes not supported yet
   # test "find references with cursor over a function called via @attr.Submodule.call", %{trace: trace} do
   #   buffer = """
   #   defmodule Caller do