small simplifications

Author: lukaszsamson

apps/language_server/lib/language_server/providers/folding_range/helpers.ex

@@ -3,12 +3,11 @@ defmodule ElixirLS.LanguageServer.Providers.FoldingRange.Helpers do
 
   def first_and_last_of_list([]), do: :empty_list
 
+  def first_and_last_of_list([head]), do: {head, head}
+
+  def first_and_last_of_list([head, last]), do: {head, last}
+
   def first_and_last_of_list([head | tail]) do
-    tail
-    |> List.last()
-    |> case do
-      nil -> {head, head}
-      last -> {head, last}
-    end
+    {head, List.last(tail)}
   end
 end

apps/language_server/lib/language_server/providers/folding_range/token.ex

@@ -6,8 +6,6 @@ defmodule ElixirLS.LanguageServer.Providers.FoldingRange.Token do
   """
 
   alias ElixirSense.Core.Normalized.Tokenizer
-  alias ElixirLS.LanguageServer.JsonRpc
-  require Logger
 
   @type t :: {atom(), {non_neg_integer(), non_neg_integer(), any()}, any()}
 
@@ -22,7 +20,7 @@ defmodule ElixirLS.LanguageServer.Providers.FoldingRange.Token do
     reversed_tokens
     # This reverses the tokens, but they come out of Tokenizer.tokenize/1
     # already reversed.
-    |> Enum.reduce_while({:ok, []}, fn tuple, {:ok, acc} ->
+    |> Enum.reduce([], fn tuple, acc ->
       tuple =
         case tuple do
           {a, {b1, b2, b3}} ->
@@ -44,29 +42,9 @@ defmodule ElixirLS.LanguageServer.Providers.FoldingRange.Token do
 
           {:list_heredoc, {b1, b2, b3}, _, _} ->
             {:list_heredoc, {b1 - 1, b2 - 1, b3}, nil}
-
-          # raise here?
-          error ->
-            Logger.warning("Unmatched token: #{inspect(error)}")
-
-            JsonRpc.telemetry(
-              "folding_ranges_error",
-              %{"elixir_ls.folding_ranges_error" => inspect(error)},
-              %{}
-            )
-
-            :error
         end
 
-      if tuple == :error do
-        {:halt, :error}
-      else
-        {:cont, {:ok, [tuple | acc]}}
-      end
+      [tuple | acc]
     end)
-    |> case do
-      {:ok, formatted_tokens} -> formatted_tokens
-      _ -> []
-    end
   end
 end