Fix tests on windows

Fixes #685

Author: lukaszsamson

apps/language_server/lib/language_server/providers/hover.ex

@@ -165,15 +165,19 @@ defmodule ElixirLS.LanguageServer.Providers.Hover do
   defp third_dep?(_source, nil), do: false
 
   defp third_dep?(source, project_dir) do
-    prefix = project_dir <> "/deps"
+    prefix = deps_path(project_dir)
     String.starts_with?(source, prefix)
   end
 
   defp third_dep_name(source, project_dir) do
-    prefix = project_dir <> "/deps/"
+    prefix = deps_path(project_dir) <> "/"
     String.replace_prefix(source, prefix, "") |> String.split("/") |> hd()
   end
 
+  defp deps_path(project_dir) do
+    project_dir |> Path.expand() |> Path.join("deps")
+  end
+
   defp builtin?(source) do
     @builtin_flag |> Enum.any?(fn y -> String.contains?(source, y) end)
   end

apps/language_server/lib/language_server/server.ex

@@ -916,13 +916,16 @@ defmodule ElixirLS.LanguageServer.Server do
 
     test_pattern = get_in(state.settings, ["testPattern", app_name]) || "*_test.exs"
 
+    file_path = Path.expand(file_path)
+
     Mix.Utils.extract_files(test_paths, test_pattern)
     |> Enum.any?(fn path -> String.ends_with?(file_path, path) end)
   end
 
   defp is_test_file?(file_path) do
     test_paths = Mix.Project.config()[:test_paths] || ["test"]
     test_pattern = Mix.Project.config()[:test_pattern] || "*_test.exs"
+    file_path = Path.expand(file_path)
 
     Mix.Utils.extract_files(test_paths, test_pattern)
     |> Enum.map(&Path.absname/1)

apps/language_server/test/providers/formatting_test.exs

@@ -486,8 +486,10 @@ defmodule ElixirLS.LanguageServer.Providers.FormattingTest do
       assert_formatted("test/file.exs", project_dir)
       refute_formatted("test/file.ex", project_dir)
 
-      assert_formatted("symlink/file.exs", project_dir)
-      refute_formatted("symlink/file.ex", project_dir)
+      unless is_windows() do
+        assert_formatted("symlink/file.exs", project_dir)
+        refute_formatted("symlink/file.ex", project_dir)
+      end
 
       File.mkdir!("#{project_dir}/test/foo")
       refute_formatted("test/foo/file.ex", project_dir)

apps/language_server/test/server_test.exs

@@ -730,7 +730,7 @@ defmodule ElixirLS.LanguageServer.ServerTest do
     Server.receive_packet(server, did_open(uri, "elixir", 1, code))
     Server.receive_packet(server, completion_req(1, uri, 2, 25))
 
-    resp = assert_receive(%{"id" => 1}, 5000)
+    resp = assert_receive(%{"id" => 1}, 10000)
 
     assert response(1, %{
              "isIncomplete" => true,
@@ -1280,7 +1280,7 @@ defmodule ElixirLS.LanguageServer.ServerTest do
       file_uri = SourceFile.Path.to_uri(file_path)
       file_absolute_path = SourceFile.Path.from_uri(file_uri)
       text = File.read!(file_path)
-      project_dir = SourceFile.Path.from_uri("#{root_uri()}/apps/app1")
+      project_dir = SourceFile.Path.absolute_from_uri("#{root_uri()}/apps/app1")
 
       initialize(server, %{"enableTestLenses" => true})
 
@@ -1365,7 +1365,7 @@ defmodule ElixirLS.LanguageServer.ServerTest do
       file_uri = SourceFile.Path.to_uri(file_path)
       file_absolute_path = SourceFile.Path.from_uri(file_uri)
       text = File.read!(file_path)
-      project_dir = SourceFile.Path.from_uri(root_uri())
+      project_dir = SourceFile.Path.absolute_from_uri(root_uri())
 
       initialize(server, %{"enableTestLenses" => true})
 
@@ -1427,7 +1427,7 @@ defmodule ElixirLS.LanguageServer.ServerTest do
       file_uri = SourceFile.Path.to_uri(file_path)
       file_absolute_path = SourceFile.Path.from_uri(file_uri)
       text = File.read!(file_path)
-      project_dir = SourceFile.Path.from_uri("#{root_uri()}/apps/app1")
+      project_dir = SourceFile.Path.absolute_from_uri("#{root_uri()}/apps/app1")
 
       initialize(server, %{
         "enableTestLenses" => true,

apps/language_server/test/source_file/invalid_project_test.exs

@@ -7,7 +7,7 @@ defmodule ElixirLS.LanguageServer.SourceFile.InvalidProjectTest do
 
   def appropriate_formatter_function_name(_) do
     formatter_function =
-      if function_exported?(Mix.Tasks.Format, :formatter_for_file, 1) do
+      if Version.match?(System.version(), ">= 1.13.0") do
         :formatter_for_file
       else
         :formatter_opts_for_file
@@ -16,7 +16,7 @@ defmodule ElixirLS.LanguageServer.SourceFile.InvalidProjectTest do
     {:ok, formatter_name: formatter_function}
   end
 
-  describe "formatter_for " do
+  describe "formatter_for" do
     setup [:appropriate_formatter_function_name]
 
     test "should handle syntax errors", ctx do

apps/language_server/test/source_file/path_test.exs

@@ -130,7 +130,7 @@ defmodule ElixirLS.LanguageServer.SourceFile.PathTest do
   describe "to_uri/1" do
     # tests based on cases from https://github.com/microsoft/vscode-uri/blob/master/src/test/uri.test.ts
     test "unix path" do
-      with_os(:linux, fn ->
+      unless is_windows() do
         assert "file:///nodes%2B%23.ex" == to_uri("/nodes+#.ex")
         assert "file:///coding/c%23/project1" == to_uri("/coding/c#/project1")
 
@@ -139,7 +139,7 @@ defmodule ElixirLS.LanguageServer.SourceFile.PathTest do
 
         assert "file:///foo/%25A0.txt" == to_uri("/foo/%A0.txt")
         assert "file:///foo/%252e.txt" == to_uri("/foo/%2e.txt")
-      end)
+      end
     end
 
     test "windows path" do