Skip to content

Commit b27dca4

Browse files
authored
Merge pull request #349 from elimu-ai/239-query-letters-by-sort-order-in-loadallbylettersound
query letters & sounds by sort order in loadallbylettersound
2 parents 6ba94bf + 4974753 commit b27dca4

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ See https://jitpack.io/#ai.elimu/content-provider/ for the latest version availa
4848

4949
1. Publish the library to your local Maven repository:
5050
```sh
51-
./gradlew clean utils:publishReleasePublicationToMavenLocal
51+
./gradlew clean build utils:publishAarPublicationToMavenLocal
5252
```
5353
2. In the app that will be testing the `-SNAPSHOT` version of the library, add `mavenLocal()`:
5454
```diff

app/src/main/java/ai/elimu/content_provider/room/dao/LetterDao.kt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,10 @@ interface LetterDao {
2424
@Query("SELECT * FROM Letter ORDER BY usageCount DESC")
2525
fun loadAllOrderedByUsageCountCursor(): Cursor
2626

27-
@Query("SELECT * FROM Letter l WHERE l.id IN (SELECT letters_id FROM LetterSound_Letter WHERE LetterSound_id = :letterSoundId)")
27+
@Query("SELECT * FROM Letter l " +
28+
"INNER JOIN LetterSound_Letter lsl ON l.id = lsl.letters_id " +
29+
"WHERE lsl.LetterSound_id = :letterSoundId " +
30+
"ORDER BY lsl.letters_ORDER")
2831
fun loadAllByLetterSound(letterSoundId: Long?): Cursor
2932

3033
@Update

app/src/main/java/ai/elimu/content_provider/room/dao/SoundDao.kt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,10 @@ interface SoundDao {
2424
@Query("SELECT * FROM Sound ORDER BY usageCount DESC")
2525
fun loadAllOrderedByUsageCountCursor(): Cursor
2626

27-
@Query("SELECT * FROM Sound s WHERE s.id IN (SELECT sounds_id FROM LetterSound_Sound WHERE LetterSound_id = :letterSoundId)")
27+
@Query("SELECT * FROM Sound s " +
28+
"INNER JOIN LetterSound_Sound lss ON s.id = lss.sounds_id " +
29+
"WHERE lss.LetterSound_id = :letterSoundId " +
30+
"ORDER BY lss.sounds_ORDER")
2831
fun loadAllByLetterSound(letterSoundId: Long?): Cursor
2932

3033
@Update

0 commit comments

Comments
 (0)