Downloading pfp/room picture corrupts it

[orestbandera9]

When I attempt to download it, I do not get the original file that I expect. Instead I get a corrupted version that lacks a usable file extension (.bin)

I usually resort to manually finding out what file type it is and then adding the correct extension, although this is still ridiculous.

[bmarty]

Hello @orestbandera9 , thanks for reporting. Ideally you would attach the problematic file to the issue, and the content of the Event so that we can investigate. Also, do you know which client has sent the file to the room? And do other clients (especially Element X iOS) face the same issue when downloading the file?

[jmartinesp]

I think the problem is all we have when we download and display the avatar is the MXC url, which has no mime type, and we have no good way to get it from the image itself other than adding some library to read its header I guess.

From what I could test on iOS, they just assume the image is a JPG even when it's not - I have a room with a PNG icon that still has transparency and when exported it's done with a .jpeg extension, but the exported file is treated as a PNG by most image viewers and keeps the alpha channel.

[bmarty]

Ha ofc. I missed that pfp means profile picture 🤦

[jmartinesp]

We could try using the file format's magic numbers to detect which type of image file it is though. It's more complex for video containers, but it should be fairly simple for images.

[bmarty]

I can give it a try