Skip to content

Commit 30bf6d2

Browse files
committed
Iterate on FloatingActionButton shape and colors.
1 parent ef11a3b commit 30bf6d2

File tree

3 files changed

+5
-12
lines changed
  • features
    • home/impl/src/main/kotlin/io/element/android/features/home/impl
    • messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline
  • libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/theme/components

3 files changed

+5
-12
lines changed

features/home/impl/src/main/kotlin/io/element/android/features/home/impl/HomeView.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,6 @@ private fun HomeScaffold(
274274
floatingActionButton = {
275275
if (state.displayActions) {
276276
FloatingActionButton(
277-
containerColor = ElementTheme.colors.iconPrimary,
278277
onClick = onCreateRoomClick
279278
) {
280279
Icon(

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/TimelineView.kt

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ import androidx.compose.foundation.lazy.LazyColumn
2323
import androidx.compose.foundation.lazy.LazyListState
2424
import androidx.compose.foundation.lazy.items
2525
import androidx.compose.foundation.lazy.rememberLazyListState
26-
import androidx.compose.foundation.shape.CircleShape
2726
import androidx.compose.material3.FloatingActionButtonDefaults
2827
import androidx.compose.runtime.Composable
2928
import androidx.compose.runtime.CompositionLocalProvider
@@ -47,7 +46,6 @@ import androidx.compose.ui.platform.rememberNestedScrollInteropConnection
4746
import androidx.compose.ui.res.stringResource
4847
import androidx.compose.ui.tooling.preview.PreviewParameter
4948
import androidx.compose.ui.unit.dp
50-
import io.element.android.compound.theme.ElementTheme
5149
import io.element.android.compound.tokens.generated.CompoundIcons
5250
import io.element.android.features.messages.impl.crypto.sendfailure.resolve.ResolveVerifiedUserSendFailureView
5351
import io.element.android.features.messages.impl.timeline.components.TimelineItemRow
@@ -363,10 +361,8 @@ private fun JumpToBottomButton(
363361
FloatingActionButton(
364362
onClick = onClick,
365363
elevation = FloatingActionButtonDefaults.elevation(4.dp, 4.dp, 4.dp, 4.dp),
366-
shape = CircleShape,
364+
shape = FloatingActionButtonDefaults.smallShape,
367365
modifier = Modifier.size(36.dp),
368-
containerColor = ElementTheme.colors.bgSubtleSecondary,
369-
contentColor = ElementTheme.colors.iconSecondary
370366
) {
371367
Icon(
372368
modifier = Modifier

libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/theme/components/FloatingActionButton.kt

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,16 @@ package io.element.android.libraries.designsystem.theme.components
1010
import androidx.compose.foundation.interaction.MutableInteractionSource
1111
import androidx.compose.foundation.layout.Box
1212
import androidx.compose.foundation.layout.padding
13-
import androidx.compose.foundation.shape.CircleShape
1413
import androidx.compose.material3.FloatingActionButtonDefaults
1514
import androidx.compose.material3.FloatingActionButtonElevation
16-
import androidx.compose.material3.contentColorFor
1715
import androidx.compose.runtime.Composable
1816
import androidx.compose.runtime.remember
1917
import androidx.compose.ui.Modifier
2018
import androidx.compose.ui.graphics.Color
2119
import androidx.compose.ui.graphics.Shape
2220
import androidx.compose.ui.tooling.preview.Preview
2321
import androidx.compose.ui.unit.dp
22+
import io.element.android.compound.theme.ElementTheme
2423
import io.element.android.compound.tokens.generated.CompoundIcons
2524
import io.element.android.libraries.designsystem.preview.ElementThemedPreview
2625
import io.element.android.libraries.designsystem.preview.PreviewGroup
@@ -31,10 +30,9 @@ import io.element.android.libraries.testtags.testTag
3130
fun FloatingActionButton(
3231
onClick: () -> Unit,
3332
modifier: Modifier = Modifier,
34-
// FloatingActionButtonDefaults.shape
35-
shape: Shape = CircleShape,
36-
containerColor: Color = FloatingActionButtonDefaults.containerColor,
37-
contentColor: Color = contentColorFor(containerColor),
33+
shape: Shape = FloatingActionButtonDefaults.shape,
34+
containerColor: Color = ElementTheme.colors.textActionAccent,
35+
contentColor: Color = ElementTheme.colors.iconOnSolidPrimary,
3836
elevation: FloatingActionButtonElevation = FloatingActionButtonDefaults.elevation(),
3937
interactionSource: MutableInteractionSource = remember { MutableInteractionSource() },
4038
content: @Composable () -> Unit,

0 commit comments

Comments
 (0)