Skip to content

Commit fac8dd3

Browse files
committed
RTE: fix API break...
1 parent d145c31 commit fac8dd3

File tree

2 files changed

+16
-13
lines changed

2 files changed

+16
-13
lines changed

vector/src/main/java/im/vector/app/features/home/room/detail/AutoCompleter.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,6 +232,7 @@ class AutoCompleter @AssistedInject constructor(
232232
private fun insertMatrixItemIntoRichTextEditor(editorEditText: EditorEditText, matrixItem: MatrixItem) {
233233
if (matrixItem is MatrixItem.EveryoneInRoomItem) {
234234
editorEditText.replaceTextSuggestion(matrixItem.displayName)
235+
// Note: not using editorEditText.insertAtRoomMentionAtSuggestion() since we want to keep the existing look and feel of the mention for @room.
235236
return
236237
}
237238

@@ -253,7 +254,7 @@ class AutoCompleter @AssistedInject constructor(
253254
matrixItem.getBestName()
254255
}
255256

256-
editorEditText.setLinkSuggestion(url = permalink, text = linkText)
257+
editorEditText.insertMentionAtSuggestion(url = permalink, text = linkText)
257258
}
258259

259260
private fun insertMatrixItemIntoEditable(editText: EditText, editable: Editable, firstChar: Char, matrixItem: MatrixItem) {

vector/src/main/java/im/vector/app/features/home/room/detail/composer/RichTextComposerLayout.kt

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -105,10 +105,10 @@ internal class RichTextComposerLayout @JvmOverloads constructor(
105105
override val attachmentButton: ImageButton
106106
get() = views.attachmentButton
107107

108-
val richTextEditText: EditText get() =
109-
views.richTextComposerEditText
110-
val plainTextEditText: EditText get() =
111-
views.plainTextComposerEditText
108+
val richTextEditText: EditText
109+
get() = views.richTextComposerEditText
110+
val plainTextEditText: EditText
111+
get() = views.plainTextComposerEditText
112112

113113
var pillDisplayHandler: PillDisplayHandler? = null
114114

@@ -237,14 +237,16 @@ internal class RichTextComposerLayout @JvmOverloads constructor(
237237
views.composerEditTextOuterBorder.background = borderShapeDrawable
238238

239239
setupRichTextMenu()
240-
views.richTextComposerEditText.mentionDisplayHandler = object : MentionDisplayHandler {
241-
override fun resolveMentionDisplay(text: String, url: String): TextDisplay =
242-
pillDisplayHandler?.resolveMentionDisplay(text, url) ?: TextDisplay.Plain
243-
244-
override fun resolveAtRoomMentionDisplay(): TextDisplay =
245-
pillDisplayHandler?.resolveAtRoomMentionDisplay() ?: TextDisplay.Plain
246-
}
247-
240+
views.richTextComposerEditText.updateStyle(
241+
styleConfig = views.richTextComposerEditText.styleConfig,
242+
mentionDisplayHandler = object : MentionDisplayHandler {
243+
override fun resolveMentionDisplay(text: String, url: String): TextDisplay =
244+
pillDisplayHandler?.resolveMentionDisplay(text, url) ?: TextDisplay.Plain
245+
246+
override fun resolveAtRoomMentionDisplay(): TextDisplay =
247+
pillDisplayHandler?.resolveAtRoomMentionDisplay() ?: TextDisplay.Plain
248+
}
249+
)
248250
updateTextFieldBorder(isFullScreen)
249251
}
250252

0 commit comments

Comments
 (0)