Skip to content

Commit ea9874a

Browse files
authored
Merge pull request #7355 from vector-im/feature/bma/check_script
Fix the check script, some folders have changed.
2 parents 92a2420 + 1a9b394 commit ea9874a

File tree

1 file changed

+26
-21
lines changed

1 file changed

+26
-21
lines changed

tools/check/check_code_quality.sh

Lines changed: 26 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -68,15 +68,14 @@ ${searchForbiddenStringsScript} ./tools/check/forbidden_strings_in_code.txt \
6868
./matrix-sdk-android/src/main/java \
6969
./matrix-sdk-android-flow/src/main/java \
7070
./library/core-utils/src/main/java \
71-
./library/jsonviewer/src/main/java \
71+
./library/external/jsonviewer/src/main/java \
7272
./library/ui-styles/src/main/java \
7373
./vector/src/main/java \
74-
./vector/src/debug/java \
75-
./vector/src/release/java \
76-
./vector/src/fdroid/java \
77-
./vector/src/gplay/java \
74+
./vector-app/src/debug/java \
75+
./vector-app/src/fdroid/java \
7876
./vector-app/src/gplay/java \
79-
./vector-app/src/main/java
77+
./vector-app/src/main/java \
78+
./vector-app/src/release/java
8079

8180
resultForbiddenStringInCode=$?
8281

@@ -93,13 +92,15 @@ echo
9392
echo "Search for forbidden patterns specific for App code..."
9493

9594
${searchForbiddenStringsScript} ./tools/check/forbidden_strings_in_code_app.txt \
95+
./library/core-utils/src/main/java \
96+
./library/external/jsonviewer/src/main/java \
97+
./library/ui-styles/src/main/java \
9698
./vector/src/main/java \
97-
./vector/src/debug/java \
98-
./vector/src/release/java \
99-
./vector/src/fdroid/java \
100-
./vector/src/gplay/java \
99+
./vector-app/src/debug/java \
100+
./vector-app/src/fdroid/java \
101101
./vector-app/src/gplay/java \
102-
./vector-app/src/main/java
102+
./vector-app/src/main/java \
103+
./vector-app/src/release/java
103104

104105
resultForbiddenStringInCodeApp=$?
105106

@@ -120,8 +121,7 @@ echo
120121
echo "Search for forbidden patterns in layouts..."
121122

122123
${searchForbiddenStringsScript} ./tools/check/forbidden_strings_in_layout.txt \
123-
./vector/src/main/res/layout \
124-
./vector-app/src/main/res/layout
124+
./vector/src/main/res/layout
125125

126126
resultForbiddenStringInLayout=$?
127127

@@ -154,17 +154,19 @@ echo "Search for kotlin files with more than ${maxLines} lines..."
154154
${checkLongFilesScript} ${maxLines} \
155155
./matrix-sdk-android/src/main/java \
156156
./matrix-sdk-android-flow/src/main/java \
157+
./library/core-utils/src/main/java \
158+
./library/external/jsonviewer/src/main/java \
159+
./library/ui-styles/src/main/java \
157160
./vector/src/androidTest/java \
158-
./vector/src/debug/java \
159-
./vector/src/fdroid/java \
160-
./vector/src/gplay/java \
161161
./vector/src/main/java \
162-
./vector/src/release/java \
163162
./vector/src/sharedTest/java \
164163
./vector/src/test/java \
165-
./vector/src/androidTest/java \
166-
./vector/src/gplay/java \
167-
./vector/src/main/java
164+
./vector-app/src/androidTest/java \
165+
./vector-app/src/debug/java \
166+
./vector-app/src/fdroid/java \
167+
./vector-app/src/gplay/java \
168+
./vector-app/src/main/java \
169+
./vector-app/src/release/java
168170

169171

170172
resultLongFiles=$?
@@ -179,8 +181,11 @@ echo "Search for png files in /drawable..."
179181
ls -1U ./vector/src/main/res/drawable/*.png
180182
resultTmp=$?
181183

184+
ls -1U ./vector-app/src/main/res/drawable/*.png
185+
resultTmp2=$?
186+
182187
# Inverse the result, cause no file found is an error for ls but this is what we want!
183-
if [[ ${resultTmp} -eq 0 ]]; then
188+
if [[ ${resultTmp} -eq 0 ]] || [[ ${resultTmp2} -eq 0 ]]; then
184189
echo "ERROR, png files detected in /drawable"
185190
resultPngInDrawable=1
186191
else

0 commit comments

Comments
 (0)