Skip to content

Commit 6feee61

Browse files
authored
Merge pull request #8711 from element-hq/dependabot/gradle/io.element.android-wysiwyg-2.22.0
Bump io.element.android:wysiwyg from 2.14.1 to 2.22.0
2 parents 431a1a6 + 644587a commit 6feee61

File tree

4 files changed

+26
-16
lines changed

4 files changed

+26
-16
lines changed

dependencies.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ ext.libs = [
101101
],
102102
element : [
103103
'opusencoder' : "io.element.android:opusencoder:1.1.0",
104-
'wysiwyg' : "io.element.android:wysiwyg:2.14.1"
104+
'wysiwyg' : "io.element.android:wysiwyg:2.22.0"
105105
],
106106
squareup : [
107107
'moshi' : "com.squareup.moshi:moshi:$moshi",

vector/src/main/java/im/vector/app/features/home/room/detail/AutoCompleter.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,6 +232,7 @@ class AutoCompleter @AssistedInject constructor(
232232
private fun insertMatrixItemIntoRichTextEditor(editorEditText: EditorEditText, matrixItem: MatrixItem) {
233233
if (matrixItem is MatrixItem.EveryoneInRoomItem) {
234234
editorEditText.replaceTextSuggestion(matrixItem.displayName)
235+
// Note: not using editorEditText.insertAtRoomMentionAtSuggestion() since we want to keep the existing look and feel of the mention for @room.
235236
return
236237
}
237238

@@ -253,7 +254,7 @@ class AutoCompleter @AssistedInject constructor(
253254
matrixItem.getBestName()
254255
}
255256

256-
editorEditText.setLinkSuggestion(url = permalink, text = linkText)
257+
editorEditText.insertMentionAtSuggestion(url = permalink, text = linkText)
257258
}
258259

259260
private fun insertMatrixItemIntoEditable(editText: EditText, editable: Editable, firstChar: Char, matrixItem: MatrixItem) {

vector/src/main/java/im/vector/app/features/home/room/detail/composer/RichTextComposerLayout.kt

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -105,10 +105,10 @@ internal class RichTextComposerLayout @JvmOverloads constructor(
105105
override val attachmentButton: ImageButton
106106
get() = views.attachmentButton
107107

108-
val richTextEditText: EditText get() =
109-
views.richTextComposerEditText
110-
val plainTextEditText: EditText get() =
111-
views.plainTextComposerEditText
108+
val richTextEditText: EditText
109+
get() = views.richTextComposerEditText
110+
val plainTextEditText: EditText
111+
get() = views.plainTextComposerEditText
112112

113113
var pillDisplayHandler: PillDisplayHandler? = null
114114

@@ -237,14 +237,16 @@ internal class RichTextComposerLayout @JvmOverloads constructor(
237237
views.composerEditTextOuterBorder.background = borderShapeDrawable
238238

239239
setupRichTextMenu()
240-
views.richTextComposerEditText.mentionDisplayHandler = object : MentionDisplayHandler {
241-
override fun resolveMentionDisplay(text: String, url: String): TextDisplay =
242-
pillDisplayHandler?.resolveMentionDisplay(text, url) ?: TextDisplay.Plain
243-
244-
override fun resolveAtRoomMentionDisplay(): TextDisplay =
245-
pillDisplayHandler?.resolveAtRoomMentionDisplay() ?: TextDisplay.Plain
246-
}
247-
240+
views.richTextComposerEditText.updateStyle(
241+
styleConfig = views.richTextComposerEditText.styleConfig,
242+
mentionDisplayHandler = object : MentionDisplayHandler {
243+
override fun resolveMentionDisplay(text: String, url: String): TextDisplay =
244+
pillDisplayHandler?.resolveMentionDisplay(text, url) ?: TextDisplay.Plain
245+
246+
override fun resolveAtRoomMentionDisplay(): TextDisplay =
247+
pillDisplayHandler?.resolveAtRoomMentionDisplay() ?: TextDisplay.Plain
248+
}
249+
)
248250
updateTextFieldBorder(isFullScreen)
249251
}
250252

vector/src/main/java/im/vector/app/features/home/room/detail/timeline/item/MessageTextItem.kt

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ import im.vector.app.features.home.room.detail.timeline.url.PreviewUrlUiState
3535
import im.vector.app.features.home.room.detail.timeline.url.PreviewUrlView
3636
import im.vector.app.features.media.ImageContentRenderer
3737
import im.vector.lib.core.utils.epoxy.charsequence.EpoxyCharSequence
38+
import io.element.android.wysiwyg.EditorStyledTextView
3839
import io.noties.markwon.MarkwonPlugin
3940
import org.matrix.android.sdk.api.extensions.orFalse
4041

@@ -138,13 +139,19 @@ abstract class MessageTextItem : AbsMessageItem<MessageTextItem.Holder>() {
138139
val previewUrlView by bind<PreviewUrlView>(R.id.messageUrlPreview)
139140
private val richMessageStub by bind<ViewStub>(R.id.richMessageTextViewStub)
140141
private val plainMessageStub by bind<ViewStub>(R.id.plainMessageTextViewStub)
141-
var richMessageView: AppCompatTextView? = null
142+
var richMessageView: EditorStyledTextView? = null
142143
private set
143144
var plainMessageView: AppCompatTextView? = null
144145
private set
145146

146147
fun requireRichMessageView(): AppCompatTextView {
147-
val view = richMessageView ?: richMessageStub.inflate().findViewById(R.id.messageTextView)
148+
val view = richMessageView ?: richMessageStub.inflate().findViewById<EditorStyledTextView>(R.id.messageTextView).also {
149+
// Required to ensure that `inlineCodeBgHelper` and `codeBlockBgHelper` are initialized
150+
it.updateStyle(
151+
styleConfig = it.styleConfig,
152+
mentionDisplayHandler = null,
153+
)
154+
}
148155
richMessageView = view
149156
return view
150157
}

0 commit comments

Comments
 (0)