Skip to content

Commit 22f69ec

Browse files
authored
Merge pull request #8743 from element-hq/feature/bma/editorIssue
Fix Rich Text Editor issues: save formatted text in draft and keep formatting when switching between modes
2 parents 204244b + 2395d72 commit 22f69ec

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

changelog.d/7466.bugfix

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Restore formatting when restoring a draft. Also keep formatting when switching composer mode.

vector/src/main/java/im/vector/app/features/home/room/detail/composer/MessageComposerFragment.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ import com.vanniktech.emoji.EmojiPopup
4747
import dagger.hilt.android.AndroidEntryPoint
4848
import im.vector.app.R
4949
import im.vector.app.core.error.fatalError
50+
import im.vector.app.core.extensions.orEmpty
5051
import im.vector.app.core.extensions.registerStartForActivityResult
5152
import im.vector.app.core.extensions.showKeyboard
5253
import im.vector.app.core.glide.GlideApp
@@ -255,7 +256,7 @@ class MessageComposerFragment : VectorBaseFragment<FragmentComposerBinding>(), A
255256
it.isRecordingVoiceBroadcast && !requireActivity().isChangingConfigurations -> timelineViewModel.handle(VoiceBroadcastAction.Recording.Pause)
256257
else -> {
257258
timelineViewModel.handle(VoiceBroadcastAction.Listening.Pause)
258-
messageComposerViewModel.handle(MessageComposerAction.OnEntersBackground(composer.text.toString()))
259+
messageComposerViewModel.handle(MessageComposerAction.OnEntersBackground(composer.formattedText ?: composer.text.orEmpty().toString()))
259260
}
260261
}
261262
}
@@ -403,7 +404,7 @@ class MessageComposerFragment : VectorBaseFragment<FragmentComposerBinding>(), A
403404
}
404405

405406
override fun onTextChanged(text: CharSequence) {
406-
messageComposerViewModel.handle(MessageComposerAction.OnTextChanged(text))
407+
messageComposerViewModel.handle(MessageComposerAction.OnTextChanged(composer.formattedText ?: text))
407408
}
408409

409410
override fun onFullScreenModeChanged() = withState(messageComposerViewModel) { state ->

0 commit comments

Comments
 (0)