No need to freeze empty RealmList

bmarty · bmarty · commit 0b5e0fea72e0 · 2023-01-17T16:32:49.000+01:00
This was the source of growing memory usage. Non empty result are supposed to be temporary, so this is fine.
diff --git a/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/room/timeline/SendingEventsDataSource.kt b/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/room/timeline/SendingEventsDataSource.kt
@@ -72,7 +72,8 @@ internal class RealmSendingEventsDataSource(
         if (frozenSendingTimelineEvents?.isValid == true) {
             frozenSendingTimelineEvents?.realm?.close()
         }
-        frozenSendingTimelineEvents = sendingEvents?.freeze()
+        // Do not freeze empty list
+        frozenSendingTimelineEvents = sendingEvents?.takeIf { it.isNotEmpty() }?.freeze()
     }
 
     override fun buildSendingEvents(): List<TimelineEvent> {

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,8 @@ internal class RealmSendingEventsDataSource(`
`72`	`72`	`if (frozenSendingTimelineEvents?.isValid == true) {`
`73`	`73`	`frozenSendingTimelineEvents?.realm?.close()`
`74`	`74`	`}`
`75`		`- frozenSendingTimelineEvents = sendingEvents?.freeze()`
	`75`	`+ // Do not freeze empty list`
	`76`	`+ frozenSendingTimelineEvents = sendingEvents?.takeIf { it.isNotEmpty() }?.freeze()`
`76`	`77`	`}`
`77`	`78`
`78`	`79`	`override fun buildSendingEvents(): List<TimelineEvent> {`