From 72eb97d72219366b7ba81f6f97251ab2a13150be Mon Sep 17 00:00:00 2001 From: Simon Pintarelli Date: Thu, 17 Apr 2025 19:33:26 +0200 Subject: [PATCH 1/3] add -Werror --- CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 87c84f374..896dfbf17 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -88,12 +88,12 @@ if (NOT CMAKE_BUILD_TYPE) endif() if(${CMAKE_CXX_COMPILER_ID} STREQUAL "GNU" OR ${CMAKE_CXX_COMPILER_ID} STREQUAL "Clang") - set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall") + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Werror") set(CMAKE_CXX_FLAGS_DEBUG "-O0 -g -ggdb -DDEBUG") set(CMAKE_CXX_FLAGS_RELEASE "-O3 -DNDEBUG") set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-g -ggdb -O2") elseif(${CMAKE_CXX_COMPILER_ID} STREQUAL "Intel") - set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}") + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall") set(CMAKE_CXX_FLAGS_DEBUG "-O0 -g -DDEBUG") set(CMAKE_CXX_FLAGS_RELEASE "-O3 -DNDEBUG") set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-g -O2") From 0c62c97540fe07f9be210300e261869900425b83 Mon Sep 17 00:00:00 2001 From: Simon Pintarelli Date: Thu, 17 Apr 2025 19:46:01 +0200 Subject: [PATCH 2/3] add verbose install --- ci/build-cpu.sh | 2 +- ci/build-cuda.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ci/build-cpu.sh b/ci/build-cpu.sh index 2117439df..25f38ba01 100755 --- a/ci/build-cpu.sh +++ b/ci/build-cpu.sh @@ -20,7 +20,7 @@ spack -e ./spack-env develop -p $PWD sirius@develop cat ./spack-env/spack.yaml spack -e ./spack-env concretize -spack -e ./spack-env install +spack -e ./spack-env install -v # the tar pipe below expects a relative path builddir=$(spack -e ./spack-env location -b sirius) diff --git a/ci/build-cuda.sh b/ci/build-cuda.sh index 39cb7b8b1..1764bfd03 100755 --- a/ci/build-cuda.sh +++ b/ci/build-cuda.sh @@ -22,7 +22,7 @@ spack -e ./spack-env develop -p $PWD sirius@develop cat ./spack-env/spack.yaml spack -e ./spack-env concretize -spack -e ./spack-env install +spack -e ./spack-env install -v # the tar pipe below expects a relative path builddir=$(spack -e ./spack-env location -b sirius) From aaa91cc820fa681aba609db6dabfbc7712991373 Mon Sep 17 00:00:00 2001 From: Simon Pintarelli Date: Thu, 15 May 2025 14:52:02 +0200 Subject: [PATCH 3/3] add keep_werror spack config --- ci/build-cpu.sh | 1 + ci/build-cuda.sh | 1 + 2 files changed, 2 insertions(+) diff --git a/ci/build-cpu.sh b/ci/build-cpu.sh index 25f38ba01..d9fca0e68 100755 --- a/ci/build-cpu.sh +++ b/ci/build-cpu.sh @@ -6,6 +6,7 @@ export SPACK_SYSTEM_CONFIG_PATH=/user-environment/config # make sure we keep the stage direcorty spack config --scope=user add config:build_stage:/dev/shm/spack-stage +spack config --scope=user add config:flags:keep_werror:all spack env create -d ./spack-env # add local repository with current sirius recipe diff --git a/ci/build-cuda.sh b/ci/build-cuda.sh index 1764bfd03..5dd5e23fd 100755 --- a/ci/build-cuda.sh +++ b/ci/build-cuda.sh @@ -6,6 +6,7 @@ export SPACK_SYSTEM_CONFIG_PATH=/user-environment/config # make sure we keep the stage direcorty spack config --scope=user add config:build_stage:/dev/shm/spack-stage +spack config --scope=user add config:flags:keep_werror:all spack env create -d ./spack-env # add local repository with current sirius recipe