error handling in Lookup Objects action (#56)

Author: if0s

CHANGELOG.md

@@ -1,3 +1,6 @@
+## 2.4.2 (November 18, 2022)
+* Improved error handling in `Lookup Objects` action
+
 ## 2.4.1 (October 07, 2022)
 * Fixed loop issue when records equal to `Size of Polling Page` and have same `LastModifiedDate` in `Get Updated Objects Polling` trigger
 * Update Sailor version to 2.7.0

component.json

@@ -3,7 +3,7 @@
   "description": "Customer relationship management (CRM) software & cloud computing from the leader in CRM solutions for businesses large & small.",
   "docsUrl": "https://github.com/elasticio/salesforce-component-v2",
   "url": "http://www.salesforce.com/",
-  "version": "2.4.1",
+  "version": "2.4.2",
   "authClientTypes": [
     "oauth2"
   ],

lib/salesForceClient.js

@@ -223,23 +223,26 @@ class SalesForceClient {
     const includeDeleted = options.includeDeleted || this.configuration.includeDeleted;
     const { wherePart, offset, limit } = options;
     try {
-      await this.connection.sobject(sobject)
-        .select('*')
-        .where(wherePart)
-        .offset(offset)
-        .limit(limit)
-        .scanAll(includeDeleted)
-        .on('error', (err) => {
-          this.logger.error('Salesforce returned an error');
-          throw err;
-        })
-        .on('record', (record) => {
-          records.push(record);
-        })
-        .on('end', () => {
-          this.logger.debug('Found %s records', records.length);
-        })
-        .execute({ autoFetch: true, maxFetch: limit });
+      await new Promise((resolve, reject) => {
+        this.connection.sobject(sobject)
+          .select('*')
+          .where(wherePart)
+          .offset(offset)
+          .limit(limit)
+          .scanAll(includeDeleted)
+          .on('error', (err) => {
+            this.logger.error('Salesforce returned an error');
+            reject(err);
+          })
+          .on('record', (record) => {
+            records.push(record);
+          })
+          .on('end', () => {
+            this.logger.debug('Found %s records', records.length);
+            resolve();
+          })
+          .execute({ autoFetch: true, maxFetch: limit });
+      });
     } catch (e) {
       this.logger.error('Lookup query failed');
       throw e;