Fix Error: write after end (#44)

* Fix circleci configuration to push README.md docs

Author: denyshld

.eslintrc.js

@@ -1,163 +1,6 @@
-'use strict';
-
-const OFF = 'off';
-const ERROR = 'error';
-const WARN = 'warn';
-const ALWAYS = 'always';
-const NEVER = 'never';
-
 module.exports = {
-    'parserOptions': {
-        ecmaVersion: 2019
-    },
-    'env': {
-        es6: true,
-        node: true,
-        mocha: true
-    },
-    'plugins': [
-        'mocha'
-    ],
-    'extends': 'eslint:recommended',
-    'rules': {
-        'indent': [
-            ERROR,
-            4,
-            {
-                SwitchCase: 1
-            }
-        ],
-        'linebreak-style': ERROR,
-        'quotes': [
-            WARN,
-            'single',
-            {
-                avoidEscape: true,
-                allowTemplateLiterals: true
-            }
-        ],
-        'semi': [
-            ERROR,
-            ALWAYS
-        ],
-        'func-names': ERROR,
-        'no-var': ERROR,
-        'no-empty': ERROR,
-        'no-empty-function': ERROR,
-        'brace-style': [
-            ERROR,
-            '1tbs',
-            { allowSingleLine: true }
-        ],
-        'no-multiple-empty-lines': ERROR,
-        'no-multi-spaces': ERROR,
-        'one-var': [
-            ERROR,
-            NEVER
-        ],
-        'quote-props': [
-            WARN,
-            'consistent-as-needed'
-        ],
-        'key-spacing': ERROR,
-        'space-unary-ops': [
-            ERROR,
-            {
-                words: true,
-                nonwords: false
-            }
-        ],
-        'no-spaced-func': ERROR,
-        'space-before-function-paren': [
-            ERROR,
-            {
-                anonymous: ALWAYS,
-                named: NEVER
-            }
-        ],
-        'arrow-body-style': [
-            WARN,
-            'as-needed'
-        ],
-        'array-bracket-spacing': ERROR,
-        'space-in-parens': ERROR,
-        'comma-dangle': ERROR,
-        'no-trailing-spaces': ERROR,
-        'yoda': ERROR,
-        'max-len': [
-            ERROR,
-            120
-        ],
-        'camelcase': [
-            ERROR,
-            {
-                properties: 'never'
-            }
-        ],
-        'new-cap': [
-            WARN,
-            {
-                capIsNewExceptions: ['Q']
-            }
-        ],
-        'comma-style': ERROR,
-        'curly': ERROR,
-        'object-curly-spacing': [
-            WARN,
-            ALWAYS
-        ],
-        'object-curly-newline':  [
-            ERROR,
-            {
-                ObjectExpression: {
-                    minProperties: 1
-                },
-                ObjectPattern: {
-                    multiline: true,
-                    minProperties: 5
-                }
-            }
-        ],
-        'object-property-newline': ERROR,
-        'template-curly-spacing': ERROR,
-        'dot-notation': ERROR,
-        'dot-location': [
-            ERROR,
-            'property'
-        ],
-        'func-style': [
-            ERROR,
-            'declaration',
-            {
-                allowArrowFunctions: true
-            }
-        ],
-        'eol-last': ERROR,
-        'space-infix-ops': ERROR,
-        'keyword-spacing': ERROR,
-        'space-before-blocks': ERROR,
-        'no-invalid-this': ERROR,
-        'consistent-this': ERROR,
-        'no-this-before-super': ERROR,
-        'no-unreachable': ERROR,
-        'no-sparse-arrays': ERROR,
-        'array-callback-return': ERROR,
-        'strict': [
-            WARN,
-            'global'
-        ],
-        'eqeqeq': ERROR,
-        'no-use-before-define': WARN,
-        'no-undef': ERROR,
-        'no-unused-vars': WARN,
-        'no-mixed-spaces-and-tabs': ERROR,
-        'operator-linebreak': [
-            ERROR,
-            'before'
-        ],
-        'no-console': [
-            OFF
-        ],
-        "mocha/no-exclusive-tests": "error"
-    }
-};
+  'extends': 'airbnb-base',
+  'env': {
+    'mocha': true
+  }
+};

.gitignore

@@ -27,4 +27,6 @@ build/Release
 
 # Dependency directory
 # https://www.npmjs.org/doc/misc/npm-faq.html#should-i-check-my-node_modules-folder-into-git
-node_modules
+node_modules
+
+.env

CHANGELOG.md

@@ -1,3 +1,7 @@
+## 2.0.0 (October 3, 2019)
+
+* Remove generators, improve eslint
+
 ## 1.1.6 (September 10, 2019)
 
 * Migrate from TravisCI to CircleCI

component.json

@@ -26,7 +26,7 @@
   },
   "actions" : {
     "read_action": {
-      "main": "./lib/read.js",
+      "main": "./lib/triggers/read.js",
       "title": "Read CSV attachment",
       "fields": {
         "emitAll": {

lib/actions/write.js

@@ -1,10 +1,7 @@
-'use strict';
-
 const axios = require('axios');
-const co = require('co');
 const csv = require('csv');
 const _ = require('lodash');
-const messages = require('elasticio-node').messages;
+const { messages } = require('elasticio-node');
 const client = require('elasticio-rest-node')();
 
 const util = require('../util/util');
@@ -21,79 +18,86 @@ let timeout;
 let rowCount = 0;
 let ax;
 let putUrl;
+
+let readyFlag = false;
+
 exports.init = async function init(cfg) {
-    return co(function* gen() {
-
-        const delimiter = cfg.writer.separator || ',';
-        const header = cfg.includeHeaders !== 'No';
-        console.log('Using delimiter: \'%s\'', delimiter);
-        const options = {
-            header,
-            delimiter
-        };
-
-        if (cfg.writer.columns) {
-
-            const columns = Object.keys(_.keyBy(cfg.writer.columns, 'property'));
-
-            console.log('Configured column names:', columns);
-            options.columns = columns;
-        }
-
-        stringifier = csv.stringify(options);
-        signedUrl = yield client.resources.storage.createSignedUrl();
-        putUrl = signedUrl.put_url;
-        console.log('CSV file to be uploaded file to uri=%s', putUrl);
-        ax = axios.create();
-        util.addRetryCountInterceptorToAxios(ax);
-    });
+  const delimiter = cfg.writer.separator || ',';
+  const header = cfg.includeHeaders !== 'No';
+  console.log('Using delimiter: \'%s\'', delimiter);
+  const options = {
+    header,
+    delimiter,
+  };
+
+  if (cfg.writer.columns) {
+    const columns = Object.keys(_.keyBy(cfg.writer.columns, 'property'));
+
+    console.log('Configured column names:', columns);
+    options.columns = columns;
+  }
+
+  stringifier = csv.stringify(options);
+  signedUrl = await client.resources.storage.createSignedUrl();
+  putUrl = signedUrl.put_url;
+  console.log('CSV file to be uploaded file to uri=%s', putUrl);
+  ax = axios.create();
+  util.addRetryCountInterceptorToAxios(ax);
+  readyFlag = true;
 };
 
 exports.process = async function ProcessAction(msg, cfg) {
-    // eslint-disable-next-line consistent-this
-    const self = this;
-
-    if (timeout) {
-        clearTimeout(timeout);
-    }
-
-
-    timeout = setTimeout(() => {
-        console.log('Closing the stream due to inactivity');
-        co(function* gen() {
-            const finalRowCount = rowCount;
-            console.log('The resulting CSV file contains %s rows', finalRowCount);
-            ax.put(putUrl, stringifier ,{
-                method: 'PUT',
-                timeout: REQUEST_TIMEOUT,
-                retry: REQUEST_MAX_RETRY,
-                delay: REQUEST_RETRY_DELAY,
-                maxContentLength: REQUEST_MAX_CONTENT_LENGTH
-            });
-            stringifier.end();
-            const messageToEmit = messages.newMessageWithBody({
-                rowCount: finalRowCount
-            });
-            const fileName = messageToEmit.id + '.csv';
-            messageToEmit.attachments[fileName] = {
-                'content-type': 'text/csv',
-                'url': signedUrl.get_url
-            };
-            signedUrl = null;
-            rowCount = 0;
-            console.log('Emitting message %j', messageToEmit);
-            yield self.emit('data', messageToEmit);
-            yield exports.init(cfg);
-        });
-    }, TIMEOUT_BETWEEN_EVENTS);
-    let row = msg.body.writer;
-    console.log(`Incoming data: ${JSON.stringify(row)}`);
-    if (cfg.writer.columns) {
-        const columns = Object.keys(_.keyBy(cfg.writer.columns, 'property'));
-        row = _.pick(row, columns);
-    }
-    console.log(`Writing Row: ${JSON.stringify(row)}`);
-    stringifier.write(row);
-    rowCount++;
-    await this.emit('end');
+  // eslint-disable-next-line consistent-this
+  const self = this;
+
+  while (!readyFlag) {
+    // eslint-disable-next-line no-loop-func,no-await-in-loop
+    await new Promise(resolve => timeout(resolve, 100));
+  }
+
+  if (timeout) {
+    clearTimeout(timeout);
+  }
+
+  timeout = setTimeout(async () => {
+    readyFlag = false;
+
+    console.log('Closing the stream due to inactivity');
+
+    const finalRowCount = rowCount;
+    console.log('The resulting CSV file contains %s rows', finalRowCount);
+    ax.put(putUrl, stringifier, {
+      method: 'PUT',
+      timeout: REQUEST_TIMEOUT,
+      retry: REQUEST_MAX_RETRY,
+      delay: REQUEST_RETRY_DELAY,
+      maxContentLength: REQUEST_MAX_CONTENT_LENGTH,
+    });
+    stringifier.end();
+
+    const messageToEmit = messages.newMessageWithBody({
+      rowCount: finalRowCount,
+    });
+    const fileName = `${messageToEmit.id}.csv`;
+    messageToEmit.attachments[fileName] = {
+      'content-type': 'text/csv',
+      url: signedUrl.get_url,
+    };
+    signedUrl = null;
+    rowCount = 0;
+    console.log('Emitting message %j', messageToEmit);
+    await self.emit('data', messageToEmit);
+  }, TIMEOUT_BETWEEN_EVENTS);
+
+  let row = msg.body.writer;
+  console.log(`Incoming data: ${JSON.stringify(row)}`);
+  if (cfg.writer.columns) {
+    const columns = Object.keys(_.keyBy(cfg.writer.columns, 'property'));
+    row = _.pick(row, columns);
+  }
+  console.log(`Writing Row: ${JSON.stringify(row)}`);
+  stringifier.write(row);
+  rowCount += 1;
+
+  await self.emit('end');
 };