Upgrade to sailor 2.6.18-dev (#75)

* Upgrade to sailor 2.6.18
* Annual code audit to check if any potentially sensitive data is logged

Author: denyshld

CHANGELOG.md

@@ -1,3 +1,7 @@
+## 2.1.5 (October 30, 2020)
+
+Upgrade to sailor 2.6.18
+
 ## 2.1.4 (August 21, 2020)
 
 Minor asynchronicity improvement.

lib/actions/write.js

@@ -33,15 +33,13 @@ async function init(cfg) {
 
   if (cfg.writer.columns) {
     const columns = Object.keys(_.keyBy(cfg.writer.columns, 'property'));
-
-    logger.trace('Configured column names:', columns);
     options.columns = columns;
   }
 
   stringifier = csv.stringify(options);
   signedUrl = await client.resources.storage.createSignedUrl();
   putUrl = signedUrl.put_url;
-  logger.trace('CSV file to be uploaded file to uri=%s', putUrl);
+  logger.trace('Uploading CSV file');
   ax = axios.create();
   util.addRetryCountInterceptorToAxios(ax);
   readyFlag = true;
@@ -86,18 +84,16 @@ async function ProcessAction(msg, cfg) {
     };
     signedUrl = null;
     rowCount = 0;
-    self.logger.trace('Emitting message %j', messageToEmit);
+    self.logger.trace('Emitting message');
     await self.emit('data', messageToEmit);
     await init(cfg);
   }, TIMEOUT_BETWEEN_EVENTS);
 
   let row = msg.body.writer;
-  self.logger.trace(`Incoming data: ${JSON.stringify(row)}`);
   if (cfg.writer.columns) {
     const columns = Object.keys(_.keyBy(cfg.writer.columns, 'property'));
     row = _.pick(row, columns);
   }
-  self.logger.trace(`Writing Row: ${JSON.stringify(row)}`);
   stringifier.write(row);
   rowCount += 1;
 

lib/actions/writeFromArray.js

@@ -52,7 +52,7 @@ async function init(cfg) {
   stringifier = csv.stringify(options);
   signedUrl = await client.resources.storage.createSignedUrl();
   putUrl = signedUrl.put_url;
-  logger.trace('CSV file to be uploaded file to uri=%s', putUrl);
+  logger.trace('Uploading CSV file');
   ax = axios.create();
   util.addRetryCountInterceptorToAxios(ax);
 }
@@ -66,7 +66,6 @@ async function ProcessAction(msg) {
 
   const columns = Object.keys(inputArray[0]);
   rowCount = inputArray.length;
-  logger.trace('Configured column names:', columns);
   let row = {};
 
   await _.each(inputArray, async (item) => {
@@ -114,7 +113,7 @@ async function ProcessAction(msg) {
     'content-type': 'text/csv',
     url: signedUrl.get_url,
   };
-  self.logger.trace('Emitting message %j', messageToEmit);
+  self.logger.trace('Emitting message');
   await self.emit('data', messageToEmit);
   await self.emit('end');
 }

lib/actions/writeFromJson.js

@@ -56,7 +56,7 @@ async function init(cfg) {
   stringifier = csv.stringify(options);
   signedUrl = await client.resources.storage.createSignedUrl();
   putUrl = signedUrl.put_url;
-  logger.trace('CSV file to be uploaded file to uri=%s', putUrl);
+  logger.trace('Uploading CSV file');
   ax = axios.create();
   util.addRetryCountInterceptorToAxios(ax);
   readyFlag = true;
@@ -68,8 +68,6 @@ async function ProcessAction(msg, cfg) {
   const { inputObject } = msg.body;
 
   const columns = Object.keys(inputObject);
-  logger.trace('Configured column names:', columns);
-
   const values = Object.values(inputObject);
   // eslint-disable-next-line no-restricted-syntax
   for (const value of values) {
@@ -114,16 +112,13 @@ async function ProcessAction(msg, cfg) {
     };
     signedUrl = null;
     rowCount = 0;
-    self.logger.trace('Emitting message %j', messageToEmit);
+    self.logger.trace('Emitting message');
     await self.emit('data', messageToEmit);
     await init(cfg);
   }, TIMEOUT_BETWEEN_EVENTS);
 
   let row = inputObject;
-  self.logger.trace(`Incoming data: ${JSON.stringify(row)}`);
   row = _.pick(row, columns);
-
-  self.logger.trace(`Writing Row: ${JSON.stringify(row)}`);
   stringifier.write(row);
   rowCount += 1;
 

lib/triggers/read.js

@@ -62,12 +62,11 @@ async function ProcessRead(msg, cfg) {
   let index = 0;
   const separator = cfg.reader ? cfg.reader.separator || ',' : ',';
   const startRow = cfg.reader ? cfg.reader.startRow || 0 : 0;
-  that.logger.trace('Incoming message is %j', msg);
   if (!csvURL || csvURL.length === 0) {
     // Now let's check for the attachment
     if (msg && msg.attachments && Object.keys(msg.attachments).length > 0) {
       const key = Object.keys(msg.attachments)[0];
-      that.logger.trace('Found attachment key=%s attachment=%j', key, msg.attachments[key]);
+      that.logger.trace('Attachment found');
       csvURL = msg.attachments[key].url;
     } else {
       that.logger.error('URL of the CSV is missing');
@@ -121,7 +120,7 @@ async function ProcessRead(msg, cfg) {
   const writer = new CsvWriter();
   writer.logger = that.logger;
 
-  that.logger.debug('Sending GET request to url=%s', csvURL);
+  that.logger.debug('Sending GET request to csv url');
   const ax = axios.create();
   util.addRetryCountInterceptorToAxios(ax);
   const response = await ax({
@@ -132,7 +131,7 @@ async function ProcessRead(msg, cfg) {
     retry: REQUEST_MAX_RETRY,
     delay: REQUEST_RETRY_DELAY,
   });
-  that.logger.debug('Have got response status=%s headers=%j', response.status, response.headers);
+  that.logger.debug('Have got response status=%s', response.status);
   if (response.status !== 200) {
     await that.emit('error', `Unexpected response code code=${response.status}`);
     ended = true;