Skip to content

Commit 8126701

Browse files
Update s3.tf
snyk security fixes
1 parent 89ec3fd commit 8126701

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

s3.tf

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
resource "aws_s3_bucket" "this" {
22
bucket = "${var.project_name}-${var.aws_account_id}"
33

4-
block_public_acls = true
4+
block_public_acls = true
5+
aws_s3_bucket_public_access_block = true
56

67
website {
78
redirect_all_requests_to = "https://${var.target_domain}"
@@ -17,6 +18,7 @@ resource "aws_s3_bucket" "this" {
1718

1819
resource "aws_kms_key" "this" {
1920
deletion_window_in_days = 10
21+
enable_key_rotation = true
2022
}
2123

2224
resource "aws_s3_bucket_server_side_encryption_configuration" "this" {
@@ -36,18 +38,22 @@ resource "aws_s3_bucket_versioning" "this" {
3638
versioning_configuration {
3739
status = "Enabled"
3840
}
41+
versioning.mfa_delete = true
3942
}
4043

4144
resource "aws_s3_bucket_versioning" "log_bucket" {
4245
bucket = aws_s3_bucket.log_bucket.id
4346
versioning_configuration {
4447
status = "Enabled"
4548
}
49+
versioning.mfa_delete = true
4650
}
4751

4852
resource "aws_s3_bucket" "log_bucket" {
4953
bucket = "log_bucket"
50-
block_public_acls = true
54+
block_public_acls = true
55+
aws_s3_bucket_public_access_block = true
56+
5157
}
5258

5359
resource "aws_s3_bucket_acl" "log_bucket_acl" {

0 commit comments

Comments
 (0)