Skip to content

Commit 16e55d4

Browse files
authored
Fix bug in PushQueriesIT (#127421)
When the length of the String `value` is 0, test cases get stuck in an infinite loop trying to select a different random String with length 0. This commit changes it to select a String with length 1 in this case.
1 parent 39a2554 commit 16e55d4

File tree

1 file changed

+1
-1
lines changed
  • x-pack/plugin/esql/qa/server/single-node/src/javaRestTest/java/org/elasticsearch/xpack/esql/qa/single_node

1 file changed

+1
-1
lines changed

x-pack/plugin/esql/qa/server/single-node/src/javaRestTest/java/org/elasticsearch/xpack/esql/qa/single_node/PushQueriesIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ public void testPushCaseInsensitiveEqualityOnDefaults() throws IOException {
9090
private void testPushQuery(String value, String esqlQuery, String luceneQuery, boolean filterInCompute, boolean found)
9191
throws IOException {
9292
indexValue(value);
93-
String differentValue = randomValueOtherThan(value, () -> randomAlphaOfLength(value.length()));
93+
String differentValue = randomValueOtherThan(value, () -> randomAlphaOfLength(value.length() == 0 ? 1 : value.length()));
9494

9595
String replacedQuery = esqlQuery.replaceAll("%value", value).replaceAll("%different_value", differentValue);
9696
RestEsqlTestCase.RequestObjectBuilder builder = requestObjectBuilder().query(replacedQuery + "\n| KEEP test");

0 commit comments

Comments
 (0)