run cargo clippy

This commit updates code according to clippy recommendations

Author: russcam

api_generator/src/api_generator/code_gen/params.rs

@@ -24,7 +24,7 @@ fn generate_param(tokens: &mut Tokens, e: &ApiEnum) {
         .iter()
         .filter(|v| !v.is_empty())
         .map(|v| {
-            if !v.contains("(") {
+            if !v.contains('(') {
                 (v.to_owned(), syn::Ident::from(v.to_pascal_case()))
             } else {
                 lazy_static! {

api_generator/src/api_generator/code_gen/request/request_builder.rs

@@ -368,13 +368,13 @@ impl<'a> RequestBuilder<'a> {
         accepts_nd_body: bool,
     ) -> Tokens {
         // TODO: lazy_static! for this?
-        let common_fields: Vec<Field> = common_params
+        let mut common_fields: Vec<Field> = common_params
             .iter()
             .map(Self::create_struct_field)
             .collect();
 
         // TODO: lazy_static! for this?
-        let common_builder_fns: Vec<ImplItem> =
+        let mut common_builder_fns: Vec<ImplItem> =
             common_params.iter().map(Self::create_impl_fn).collect();
 
         let supports_body = endpoint.supports_body();
@@ -408,8 +408,7 @@ impl<'a> RequestBuilder<'a> {
         }
 
         // Combine common fields with struct fields, sort and deduplicate
-        // clone common_fields, since quote!() consumes the Vec<Field>
-        fields.append(&mut common_fields.to_vec().clone());
+        fields.append(&mut common_fields);
         fields.sort_by(|a, b| a.ident.cmp(&b.ident));
         fields.dedup_by(|a, b| a.ident.eq(&b.ident));
 
@@ -438,8 +437,7 @@ impl<'a> RequestBuilder<'a> {
         }
 
         // Combine common fns with builder fns, sort and deduplicate.
-        // clone is required, since quote!() consumes the Vec<Item>
-        builder_fns.append(&mut common_builder_fns.to_vec().clone());
+        builder_fns.append(&mut common_builder_fns);
         builder_fns.sort_by(|a, b| a.ident.cmp(&b.ident));
         builder_fns.dedup_by(|a, b| a.ident.eq(&b.ident));
 

api_generator/src/api_generator/code_gen/url/url_builder.rs

@@ -340,7 +340,7 @@ impl<'a> UrlBuilder<'a> {
         syn::Stmt::Local(Box::new(syn::Local {
             pat: Box::new(syn::Pat::Ident(
                 syn::BindingMode::ByValue(syn::Mutability::Mutable),
-                url_ident.to_owned(),
+                url_ident,
                 None,
             )),
             ty: None,

api_generator/src/api_generator/mod.rs

@@ -291,7 +291,6 @@ pub fn generate(
     write_file(root, generated_dir, "root.rs")?;
 
     let generated_modules = fs::read_dir(generated_dir)?
-        .into_iter()
         .map(|r| {
             let path = r.unwrap().path();
             format!("pub mod {};", path.file_stem().unwrap().to_string_lossy())
@@ -334,7 +333,7 @@ fn write_file(input: String, dir: &PathBuf, file: &str) -> Result<(), failure::E
 
     let mut file = OpenOptions::new().append(true).write(true).open(&path)?;
     file.write_all(input.as_bytes())?;
-    file.write(b"\n")?;
+    file.write_all(b"\n")?;
 
     Ok(())
 }