Skip to content
This repository was archived by the owner on Sep 1, 2021. It is now read-only.

Commit 27f9bb1

Browse files
author
Brian Stevenson
committed
Add support for engine list pagination
1 parent 475c330 commit 27f9bb1

File tree

4 files changed

+7
-16
lines changed

4 files changed

+7
-16
lines changed

README.rst

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
Python Client for Swiftype App Search API
33
=========================================
44

5-
**Note: Swiftype App Search is currently in beta**
6-
75
About
86
=====
97

swiftype_app_search/__version__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
__title__ = 'swiftype_app_search'
22
__description__ = 'An API client for Swiftype App Search'
33
__url__ = 'https://github.com/swiftype/swiftype-app-search-python'
4-
__version__ = '0.1.2'
4+
__version__ = '0.1.3'
55
__author__ = 'Swiftype'
66
__author_email__ = 'eng@swiftype.com'

swiftype_app_search/client.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,13 +78,17 @@ def destroy_documents(self, engine_name, document_ids):
7878
data = json.dumps(document_ids)
7979
return self.swiftype_session.request('delete', endpoint, data=data)
8080

81-
def list_engines(self):
81+
def list_engines(self, current=1, size=20):
8282
"""
8383
Lists engines that the api key has access to.
84+
85+
:param current: Page of engines
86+
:param size: Number of engines to return per page
8487
:return: List of dictionaries with key value pair corresponding to the
8588
name of the engine.
8689
"""
87-
return self.swiftype_session.request('get', 'engines')
90+
data = { 'page': { 'current': current, 'size': size } }
91+
return self.swiftype_session.request('get', 'engines', data=data)
8892

8993
def get_engine(self, engine_name):
9094
"""

tests/test_client.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -78,17 +78,6 @@ def test_destroy_documents(self):
7878
response = self.client.destroy_documents(self.engine_name, [id])
7979
self.assertEqual(response, expected_return)
8080

81-
def test_list_engines(self):
82-
expected_return = [
83-
{ 'name': 'myawesomeengine' }
84-
]
85-
86-
with requests_mock.Mocker() as m:
87-
url = "{}/{}".format(self.client.swiftype_session.base_url, 'engines')
88-
m.register_uri('GET', url, json=expected_return, status_code=200)
89-
response = self.client.list_engines()
90-
self.assertEqual(response, expected_return)
91-
9281
def test_get_engine(self):
9382
engine_name = 'myawesomeengine'
9483
expected_return = [

0 commit comments

Comments
 (0)