Skip to content

Multi-line log entries #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hex-m opened this issue Feb 18, 2022 · 2 comments
Open

Multi-line log entries #46

hex-m opened this issue Feb 18, 2022 · 2 comments

Comments

@hex-m
Copy link
Contributor

hex-m commented Feb 18, 2022

The log file /var/log/bigbluebutton/post_archive.log is hard to work with, because some entries contain newlines.

Here we have an explicit newline but also dublincore.to_s is a multi-line string. Similar problem with the output of response.

In BigBlueButton.logger.info( "Mediapackage: \n" + mediapackage) just removing \n should be enough.

Another simple one.

@Arnei
Copy link
Member

Arnei commented Feb 18, 2022

Based on the given examples, I'm not quite sure what the problem is (explicit newlines in logging statements? newlines in general?). But I'm not against cleaning up the logging code, so feel free to put up a pull request.

@Arnei
Copy link
Member

Arnei commented Feb 18, 2022

Looking at these examples, some parts of the logging could use a general rework. Like, is it really useful to log the entire mediapackage after every request? But that's a different issue ^^'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants