glue_bones: create a DEF bone conditionally

generate fix: moved gluing to rig generate loop

Author: eigen-value

generate.py

@@ -351,6 +351,16 @@ def generate_rig(context, metarig):
             if scripts is not None:
                 ui_scripts += [scripts[0]]
         t.tick("Generate rigs: ")
+
+        # # Do final gluing
+        for rig in rigs:
+            if hasattr(rig, "glue"):
+                # update glue_bone rigs
+                bpy.ops.object.mode_set(mode='EDIT')
+                rig = rig.__class__(rig.obj, rig.base_bone, rig.params)
+
+                rig.glue()
+        t.tick("Glue pass")
     except Exception as e:
         # Cleanup if something goes wrong
         print("Rigify: failed to generate rig.")
@@ -524,14 +534,6 @@ def generate_rig(context, metarig):
         ctrl = obj.game.controllers[-1]
         ctrl.text = bpy.data.texts[script.name]
 
-    # # Do final gluing
-    for rig in rigs:
-        if hasattr(rig, "make_glue_constraints"):
-            # update glue_bone rigs
-            bpy.ops.object.mode_set(mode='EDIT')
-            rig = rig.__class__(rig.obj, rig.base_bone, rig.params)
-            rig.make_glue_constraints()
-
     t.tick("The rest: ")
     #----------------------------------
     # Deconfigure

rigs/experimental/glue_bone.py

@@ -1,6 +1,7 @@
 import bpy
 
-from ...utils import make_constraints_from_string
+from ...utils import make_constraints_from_string, make_deformer_name
+from ...utils import strip_org, copy_bone
 
 from .base_rig import BaseRig
 
@@ -64,6 +65,22 @@ def get_ctrls_by_position(self, position, groups=None, relative_error=0):
 
         return bones_in_range
 
+    def create_def(self):
+        """
+        If add_glue_def is True adds a DEF
+        :return:
+        """
+
+        if not self.params.add_glue_def:
+            return
+
+        bpy.ops.object.mode_set(mode='EDIT')
+        edit_bones = self.obj.data.edit_bones
+
+        def_bone = make_deformer_name(strip_org(self.base_bone))
+        def_bone = copy_bone(self.obj, self.base_bone, def_bone)
+        self.bones['glue_def'] = def_bone
+
     def make_glue_constraints(self):
 
         bpy.ops.object.mode_set(mode='OBJECT')
@@ -83,6 +100,29 @@ def make_glue_constraints(self):
         make_constraints_from_string(owner_pb, target=self.obj, subtarget=head_ctrls[0],
                                      fstring=self.params.glue_string)
 
+        if 'glue_def' in self.bones:
+            owner_pb = pose_bones[self.bones['glue_def']]
+            make_constraints_from_string(owner_pb, target=self.obj, subtarget=head_ctrls[0],
+                                         fstring="CL1.0WW0.0")
+            make_constraints_from_string(owner_pb, target=self.obj, subtarget=tail_ctrls[0],
+                                         fstring="DT1.0#ST1.0")
+
+    def glue(self):
+        """
+        Glue pass
+        :return:
+        """
+
+        self.create_def()
+        self.make_glue_constraints()
+
+    def generate(self):
+        """
+        Glue bones generate must do nothing. Glue bones pass is meant to happen after all other rigs generated
+        :return:
+        """
+        return [""]
+
 
 def create_sample(obj):
     # generated by rigify.utils.write_metarig