Skip to content

Commit f298869

Browse files
vishnu-alapatiVishnu Alapati
andauthored
Generate's operation message_protocols fails for older semantics libs (#216)
* Generate's operation message_protocols fails for older semantics libs --------- Co-authored-by: Vishnu Alapati <zalavis@seliiuts03320.seli.gic.ericsson.se>
1 parent 5dd9650 commit f298869

File tree

3 files changed

+11
-2
lines changed

3 files changed

+11
-2
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
## 2.1.11
2+
- Made changes to /message_protocols end-point to work for old REMRem-Semantics library.
3+
14
## 2.1.10
25
- Mockito framework upgraded to 5.3.1
36

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
</parent>
1111

1212
<properties>
13-
<eiffel-remrem-generate.version>2.1.10</eiffel-remrem-generate.version>
13+
<eiffel-remrem-generate.version>2.1.11</eiffel-remrem-generate.version>
1414
<eiffel-remrem-semantics.version>2.2.6</eiffel-remrem-semantics.version>
1515
</properties>
1616
<artifactId>eiffel-remrem-generate</artifactId>

service/src/main/java/com/ericsson/eiffel/remrem/generate/controller/RemremGenerateController.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,13 @@ public JsonElement getMessageProtocols() {
267267
for (MsgService service : msgServices) {
268268
JsonObject protocolObject = new JsonObject();
269269
protocolObject.addProperty("name", service.getServiceName());
270-
protocolObject.addProperty("edition", service.getProtocolEdition());
270+
try {
271+
protocolObject.addProperty("edition", service.getProtocolEdition());
272+
} catch (NoSuchMethodError | AbstractMethodError e) {
273+
// Ignored intentionally in order to ensure compatibility with
274+
// eiffel-remrem-semantics:2.2.0 and older.
275+
log.error("An old library, without implementation of MsgService.getProtocolEdition() is used. Please, upgrade to a newer library implementing eiffel-remrem-protocol-interface:2.1.2 or higher.");
276+
}
271277
array.add(protocolObject);
272278
}
273279
return array;

0 commit comments

Comments
 (0)