Add multiple test for rest post calls (#250)

* Updated how EI extracts url params, and now accepts JMESPATH
* Edited message when email rejects.
* fixed test that failed on validating notificationMeta
* Fixed Testing url-form-post
* Added test for form post subscription
* Added integration tests for more advnced rest calls

Author: Anders Breid

pom.xml

@@ -63,6 +63,12 @@
     </repositories>
 
     <dependencies>
+        <dependency>
+            <groupId>com.github.eiffel-community</groupId>
+            <artifactId>eiffel-commons</artifactId>
+            <version>0.0.4</version>
+        </dependency>
+
         <dependency>
             <groupId>org.springframework.boot</groupId>
             <artifactId>spring-boot-starter</artifactId>

src/integrationtests/java/com/ericsson/ei/integrationtests/ArtifactFlowRunnerIT.java

@@ -2,7 +2,6 @@
 
 import org.junit.BeforeClass;
 import org.junit.runner.RunWith;
-import org.springframework.test.context.TestPropertySource;
 
 import cucumber.api.CucumberOptions;
 import cucumber.api.junit.Cucumber;

src/integrationtests/java/com/ericsson/ei/integrationtests/FlowStepsIT.java

@@ -214,8 +214,9 @@ protected JsonNode getJSONFromFile(String filePath) throws IOException {
      */
     protected void waitForEventsToBeProcessed(int eventsCount) throws InterruptedException {
         // wait for all events to be processed
+        long stopTime = System.currentTimeMillis() + 60000;
         long processedEvents = 0;
-        while (processedEvents < eventsCount) {
+        while (processedEvents < eventsCount && stopTime > System.currentTimeMillis()) {
             processedEvents = countProcessedEvents(database, event_map);
             LOGGER.info("Have gotten: " + processedEvents + " out of: " + eventsCount);
             TimeUnit.MILLISECONDS.sleep(1000);

src/integrationtests/java/util/IntegrationTestBase.java

@@ -17,15 +17,26 @@
 ## (Comments)
 #Sample Feature Definition Template
 Feature: Artifact flow Integrationtest
-   Scenario: Send eiffel events for artifact flow and make sure EI is triggering on mail subscriptions
-    Given that "mail" subscription with jmespath "id=='aacc3c87-75e0-4b6d-88f5-b1a5d4e62b43'" is uploaded
-    And the rules "src/test/resources/ArtifactRules.json"
+
+  Scenario: 
+    Send eiffel events for artifact flow and make sure EI is triggering 
+    on mail subscriptions
+
+    # Setup Eiffel Intelligence
+    Given the rules "src/test/resources/ArtifactRules.json"
     And the events "src/test/resources/ArtifactFlowTestEvents.json"
     And the resulting aggregated object "src/test/resources/AggregatedDocumentInternalCompositionLatestIT.json";
-    And the expected aggregated object ID is "aacc3c87-75e0-4b6d-88f5-b1a5d4e62b43"
     And the upstream input "src/test/resources/upStreamInput.json"
+    Then the expected aggregated object ID is "aacc3c87-75e0-4b6d-88f5-b1a5d4e62b43"
+    # Setup subscription
+    Given subscription object for "MAIL" with name "MailTestSubscription" is created
+    When notification meta "some.cool.email@ericsson.com" is set in subscription
+    And rest post body media type is set to "crazy-pinguin" is set in subscription
+    And paremeter form key "" and form value "to_string(@)" is added in subscription
+    And condition "id=='aacc3c87-75e0-4b6d-88f5-b1a5d4e62b43'" at requirement index '0' is added in subscription
+    Then subscription is uploaded
+    # Send Events and Check job triggered
+    Given all previous steps passed
     When the upstream input events are sent
     And the eiffel events are sent
     Then mongodb should contain mail.
-
-

src/integrationtests/java/util/JenkinsManager.java

@@ -17,14 +17,71 @@
 ## (Comments)
 #Sample Feature Definition Template
 Feature: Source change flow integrationtest
-   Scenario: Send eiffel events for source change flow and make sure EI is triggering on REST-POST subscriptions
+
+  Scenario: 
+    Send eiffel events for source change flow and make sure EI is triggering on 
+    REST-POST subscriptions using buildWithParameters and JMESPATH extracted correct 
+    data to add to parameter
+
     Given the rules "src/test/resources/SourceChangeObjectRules.json"
     And the events "src/test/resources/TestSourceChangeObjectEvents.json"
     And the upstream input "src/test/resources/UpstreamEventsForSourceChange.json"
     And the resulting aggregated object "src/test/resources/aggregatedSourceChangeObject.json";
     And the expected aggregated object ID is "sb6efi4n-25fb-4d77-b9fd-5f2xrrefe66de47"
-    And jenkins is set up with a job "source-change-job"
-    And that "REST/POST" subscription with jmespath "id=='sb6efi4n-25fb-4d77-b9fd-5f2xrrefe66de47'" is uploaded
+    # Setup jenkins
+    Given jenkins data is prepared
+    When job token "test-token-123" is added to jenkins data
+    And parameter key "test_key" is added to jenkins data
+    And bash script "echo 'param 1 ' $test_key" is added to jenkins data
+    Then jenkins is set up with job name "sourceChangeTestJobParam"
+    # Setup subscription
+    Given subscription object for "REST/POST" with name "ParameterizedTriggerSubscription" is created
+    When notification meta "http://${jenkinsHost}:${jenkinsPort}/job/${jenkinsJobName}/buildWithParameters?token='test-token-123'&test_key=id" is set in subscription
+    And basic_auth authentication with username "admin" and password "admin" is set in subscription
+    And rest post body media type is set to "application/x-www-form-urlencoded" is set in subscription
+    And condition "id=='sb6efi4n-25fb-4d77-b9fd-5f2xrrefe66de47'" at requirement index '0' is added in subscription
+    Then subscription is uploaded
+    # Send Events and Check job triggered
+    Given all previous steps passed
     When the upstream input events are sent
-    And the eiffel events are sent
-    Then the jenkins job should have been triggered.
+    When the eiffel events are sent
+    And jenkins job status data fetched
+    Then verify jenkins job data timestamp is after test subscription was creted
+    And jenkins job status data has key "test_key" with value "sb6efi4n-25fb-4d77-b9fd-5f2xrrefe66de47"
+    And the jenkins job should be deleted
+
+  Scenario: 
+    Send eiffel events for source change flow and make sure EI is triggering on 
+    REST-POST subscriptions using buildWithParameters and JMESPATH extracted correct 
+    data to add to parameter
+
+    Given the rules "src/test/resources/SourceChangeObjectRules.json"
+    And the events "src/test/resources/TestSourceChangeObjectEvents.json"
+    And the upstream input "src/test/resources/UpstreamEventsForSourceChange.json"
+    And the resulting aggregated object "src/test/resources/aggregatedSourceChangeObject.json";
+    And the expected aggregated object ID is "sb6efi4n-25fb-4d77-b9fd-5f2xrrefe66de47"
+    # Setup jenkins
+    Given jenkins data is prepared
+    When job token "test-token-123" is added to jenkins data
+    And parameter key "test_param_1" is added to jenkins data
+    And parameter key "test_param_2" is added to jenkins data
+    And bash script "echo 'param 1 ' $test_param_1" is added to jenkins data
+    And bash script "echo 'param 2 ' $test_param_2" is added to jenkins data
+    Then jenkins is set up with job name "sourceChangeTestJobBodyJson"
+    # Setup subscription
+    Given subscription object for "REST/POST" with name "ParameterInBodyTriggerSubscription" is created
+    When notification meta "http://${jenkinsHost}:${jenkinsPort}/job/${jenkinsJobName}/build?token='test-token-123'" is set in subscription
+    And basic_auth authentication with username "admin" and password "admin" is set in subscription
+    And rest post body media type is set to "application/x-www-form-urlencoded" is set in subscription
+    And paremeter form key "json" and form value "{parameter: [{name:'test_param_1', value:'Test Input Value'}, {name:'test_param_2', value:id}]}" is added in subscription
+    And condition "id=='sb6efi4n-25fb-4d77-b9fd-5f2xrrefe66de47'" at requirement index '0' is added in subscription
+    Then subscription is uploaded
+    # Send Events and Check job triggered
+    Given all previous steps passed
+    When the upstream input events are sent
+    When the eiffel events are sent
+    And jenkins job status data fetched
+    Then verify jenkins job data timestamp is after test subscription was creted
+    And jenkins job status data has key "test_param_1" with value "Test Input Value"
+    And jenkins job status data has key "test_param_2" with value "sb6efi4n-25fb-4d77-b9fd-5f2xrrefe66de47"
+    Then the jenkins job should be deleted