Skip to content

Commit f9c86f7

Browse files
authored
Fixed PathVariable annotations for input parameters in RestApi. (#9)
1 parent 879eb3c commit f9c86f7

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/main/java/com/ericsson/ei/controller/SubscriptionControllerImpl.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
import org.springframework.http.HttpStatus;
1818
import org.springframework.http.ResponseEntity;
1919
import org.springframework.stereotype.Component;
20+
import org.springframework.web.bind.annotation.PathVariable;
2021
import org.springframework.web.bind.annotation.RequestBody;
2122

2223
import com.ericsson.ei.controller.model.Subscription;
@@ -55,7 +56,7 @@ public ResponseEntity<SubscriptionResponse> createSubscription(@RequestBody Subs
5556

5657
@Override
5758
@ApiOperation(value = "Returns the subscription rules for given subscription name")
58-
public ResponseEntity<Subscription> getSubscriptionById(String subscriptionName) {
59+
public ResponseEntity<Subscription> getSubscriptionById(@PathVariable String subscriptionName) {
5960
Subscription subscription = null;
6061
try {
6162
LOG.info("Subscription :" + subscriptionName + " fetch started");
@@ -71,7 +72,7 @@ public ResponseEntity<Subscription> getSubscriptionById(String subscriptionName)
7172

7273
@Override
7374
@ApiOperation(value = "Update the existing subscription by the subscription name")
74-
public ResponseEntity<SubscriptionResponse> updateSubscriptionById(String subscriptionName, @RequestBody Subscription subscription) {
75+
public ResponseEntity<SubscriptionResponse> updateSubscriptionById(@PathVariable String subscriptionName, @RequestBody Subscription subscription) {
7576
LOG.info("Subscription :" + subscriptionName + " update started");
7677
SubscriptionResponse subscriptionResponse = new SubscriptionResponse();
7778
if (!subscriptionService.isDuplicatedSubscription(subscription.getSubscriptionName())) {
@@ -90,7 +91,7 @@ public ResponseEntity<SubscriptionResponse> updateSubscriptionById(String subscr
9091

9192
@Override
9293
@ApiOperation(value = "Removes the subscription from the database")
93-
public ResponseEntity<SubscriptionResponse> deleteSubscriptionById(String subscriptionName) {
94+
public ResponseEntity<SubscriptionResponse> deleteSubscriptionById(@PathVariable String subscriptionName) {
9495
SubscriptionResponse subscriptionResponse = new SubscriptionResponse();
9596
LOG.info("Subscription :" + subscriptionName + " delete started");
9697
if (subscriptionService.deleteSubscription(subscriptionName)) {

0 commit comments

Comments
 (0)