Skip to content

Commit 81be5fb

Browse files
Added authentication to MongoDB (#109)
1 parent ecb6701 commit 81be5fb

File tree

3 files changed

+25
-24
lines changed

3 files changed

+25
-24
lines changed

src/functionaltests/java/com/ericsson/ei/utils/FunctionalTestBase.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import org.slf4j.Logger;
2222
import org.slf4j.LoggerFactory;
2323
import org.springframework.beans.factory.annotation.Autowired;
24+
import org.springframework.boot.autoconfigure.mongo.MongoProperties;
2425
import org.springframework.boot.test.context.SpringBootContextLoader;
2526
import org.springframework.boot.test.context.SpringBootTest;
2627
import org.springframework.test.context.ContextConfiguration;
@@ -46,10 +47,10 @@ public class FunctionalTestBase extends AbstractTestExecutionListener {
4647
private static final Logger LOGGER = LoggerFactory.getLogger(FunctionalTestBase.class);
4748

4849
@Autowired
49-
private MongoDBHandler mongoDBHandler;
50+
private MongoProperties mongoProperties;
5051

5152
public int getMongoDbPort() {
52-
return mongoDBHandler.getPort();
53+
return mongoProperties.getPort();
5354
}
5455

5556
@Override

src/main/java/com/ericsson/ei/mongodbhandler/MongoDBHandler.java

Lines changed: 18 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -17,27 +17,23 @@
1717
package com.ericsson.ei.mongodbhandler;
1818

1919
import java.util.ArrayList;
20+
import java.util.Collections;
2021
import java.util.List;
2122
import java.util.concurrent.TimeUnit;
2223

2324
import javax.annotation.PostConstruct;
2425

2526
import com.fasterxml.jackson.annotation.JsonIgnore;
27+
import com.mongodb.*;
2628
import lombok.Setter;
29+
import org.apache.commons.lang3.StringUtils;
2730
import org.bson.Document;
2831
import org.slf4j.Logger;
2932
import org.slf4j.LoggerFactory;
30-
import org.springframework.beans.factory.annotation.Value;
33+
import org.springframework.beans.factory.annotation.Autowired;
34+
import org.springframework.boot.autoconfigure.mongo.MongoProperties;
3135
import org.springframework.stereotype.Component;
3236

33-
import com.mongodb.BasicDBObject;
34-
import com.mongodb.Block;
35-
import com.mongodb.DB;
36-
import com.mongodb.DBCollection;
37-
import com.mongodb.DBObject;
38-
import com.mongodb.MongoClient;
39-
import com.mongodb.MongoWriteException;
40-
import com.mongodb.WriteResult;
4137
import com.mongodb.client.MongoCollection;
4238
import com.mongodb.client.MongoDatabase;
4339
import com.mongodb.client.model.IndexOptions;
@@ -51,30 +47,32 @@
5147
@Component
5248
public class MongoDBHandler {
5349
static Logger log = (Logger) LoggerFactory.getLogger(MongoDBHandler.class);
50+
51+
@Autowired
52+
private MongoProperties mongoProperties;
5453

5554
@Getter
5655
@Setter
5756
@JsonIgnore
5857
private MongoClient mongoClient;
5958

60-
@Getter
61-
@Value("${spring.data.mongodb.host}")
62-
private String host;
63-
64-
@Getter
65-
@Value("${spring.data.mongodb.port}")
66-
private int port;
67-
6859
// TODO establish connection automatically when Spring instantiate this
6960
// based on connection data in properties file
7061
@PostConstruct
7162
public void init() {
72-
createConnection(host, port);
63+
createConnection();
7364
}
7465

7566
// Establishing the connection to mongodb and creating a collection
76-
public void createConnection(String host, int port) {
77-
mongoClient = new MongoClient(host, port);
67+
private void createConnection() {
68+
if (!StringUtils.isBlank(mongoProperties.getUsername()) && !StringUtils.isBlank(new String(mongoProperties.getPassword()))) {
69+
ServerAddress address = new ServerAddress(mongoProperties.getHost(), mongoProperties.getPort());
70+
MongoCredential credential = MongoCredential.createCredential(mongoProperties.getUsername(),
71+
mongoProperties.getDatabase(), mongoProperties.getPassword());
72+
mongoClient = new MongoClient(address, Collections.singletonList(credential));
73+
} else {
74+
mongoClient = new MongoClient(mongoProperties.getHost(), mongoProperties.getPort());
75+
}
7876
}
7977

8078
/**

src/main/resources/application.properties

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,10 @@ spring.autoconfigure.exclude=org.springframework.boot.autoconfigure.mongo.embedd
3434
spring.data.mongodb.host: localhost
3535
spring.data.mongodb.port: 27017
3636
spring.data.mongodb.database: eiffel_intelligence
37+
# we cannot have empty username and password property here
38+
# if these properties are empty, remove or comment them
39+
#spring.data.mongodb.username:
40+
#spring.data.mongodb.password:
3741

3842
# session expiration
3943
server.session-timeout: 1200
@@ -61,8 +65,6 @@ email.subject: Email Subscription Notification
6165
notification.failAttempt: 3
6266
notification.ttl.value: 600
6367

64-
ldap.enabled: false
65-
6668
spring.mail.host:
6769
spring.mail.port:
6870
#spring.mail.username:

0 commit comments

Comments
 (0)