Skip to content

Commit 4c4f630

Browse files
authored
Subscription validation updated for MAIL (#69)
1 parent ee8713e commit 4c4f630

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/main/java/com/ericsson/ei/subscriptionhandler/SubscriptionValidator.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,9 @@ public void validateSubscription(Subscription subscription) throws SubscriptionV
4646
this.validateNotificationMessageKeyValues(subscription.getNotificationMessageKeyValues(), subscription.getRestPostBodyMediaType() );
4747
this.validateNotificationMeta(subscription.getNotificationMeta());
4848
this.validateNotificationType(subscription.getNotificationType());
49-
this.RestPostMediaType(subscription.getRestPostBodyMediaType());
49+
if(subscription.getNotificationType().equals("REST_POST")) {
50+
this.RestPostMediaType(subscription.getRestPostBodyMediaType());
51+
}
5052
// List<Requirement> reqList = subscription.getRequirements();
5153
// for (int i=0; i < reqList.size(); i++) {
5254
// this.validateJmespath(reqList.get(i).getConditions().get(0).getJmespath());
@@ -87,7 +89,7 @@ public void validateNotificationMessageKeyValues(List<NotificationMessageKeyValu
8789
String test_key = item.getFormkey();
8890
String test_value = item.getFormvalue();
8991

90-
if (restPostBodyMediaType.equals(MediaType.APPLICATION_FORM_URLENCODED.toString())) { // FORM/POST PARAMETERS
92+
if (restPostBodyMediaType != null && restPostBodyMediaType.equals(MediaType.APPLICATION_FORM_URLENCODED.toString())) { // FORM/POST PARAMETERS
9193
if((test_key == null || test_key.isEmpty() || StringUtils.isBlank(test_key)) || (test_value == null || test_value.isEmpty() || StringUtils.isBlank(test_value))){
9294
throw new SubscriptionValidationException("Value & Key in notificationMessage must have a values: " + notificationMessage);
9395
}

src/test/java/com/ericsson/ei/subscriptionhandler/test/SubscriptionValidatorTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public SubscriptionValidatorTest() {
7575
subscritptionInvalid.setSubscriptionName("Kalle1");
7676

7777
// new stuff
78-
subscritptionInvalid.setRestPostBodyMediaType(MediaType.APPLICATION_FORM_URLENCODED.toString());
78+
subscritptionInvalid.setRestPostBodyMediaType(null);
7979

8080
NotificationMessageKeyValue notificationMessageKeyValueinvalid = new NotificationMessageKeyValue();
8181
notificationMessageKeyValueinvalid.setFormkey("");

0 commit comments

Comments
 (0)