Fixed faulty subscription creation handling.

tobiasake · vasile-baluta · commit 370f3b25f81d · 2018-06-08T10:40:31.000+02:00
diff --git a/src/main/java/com/ericsson/ei/controller/SubscriptionControllerImpl.java b/src/main/java/com/ericsson/ei/controller/SubscriptionControllerImpl.java
@@ -80,7 +80,7 @@ public ResponseEntity<SubscriptionResponse> createSubscription(@RequestBody List
                 LOG.error(msg);
                 subscriptionResponse.setMsg(msg);
                 subscriptionResponse.setStatusCode(HttpStatus.PRECONDITION_FAILED.value());
-                subResponse = new ResponseEntity<>(subscriptionResponse, HttpStatus.PRECONDITION_FAILED);
+                return new ResponseEntity<>(subscriptionResponse, HttpStatus.PRECONDITION_FAILED);
             }
 
             if (!subscriptionService.doSubscriptionExist(subscription.getSubscriptionName())) {

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ public ResponseEntity<SubscriptionResponse> createSubscription(@RequestBody List`
`80`	`80`	`LOG.error(msg);`
`81`	`81`	`subscriptionResponse.setMsg(msg);`
`82`	`82`	`subscriptionResponse.setStatusCode(HttpStatus.PRECONDITION_FAILED.value());`
`83`		`- subResponse = new ResponseEntity<>(subscriptionResponse, HttpStatus.PRECONDITION_FAILED);`
	`83`	`+ return new ResponseEntity<>(subscriptionResponse, HttpStatus.PRECONDITION_FAILED);`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`if (!subscriptionService.doSubscriptionExist(subscription.getSubscriptionName())) {`