Added display of error messages from server when adding subscriptions (#79)

Anders Breid · web-flow · commit dfbf6d7d8f7c · 2018-11-01T10:31:37.000+01:00
* Fix multiple users may use frontend, request outside web gui. - Funktion to sent backend url as parameter added. - Gui users may now switch backend without affecting each other. - Before saving new instances the code will check if any new instances has been added to not overwrite instances created by other users. - switch-backend delete now recieves the backend to delete and not the backends to not delete. - If file is invalid or non existand it will be recreated. - Default back end properties may be specified in application-properties. - Default parameters may not be removed from gui but must be removed from application-properties first. - Unit tests have been added and updated. * Modified functional tests to work with the new utils changes. * Fixed some functional tests. * fixed code comments * Updated after comments * Fixed minor issues with switching back end * Added unittest for curl commando possibilities. * Extended time out to 11s * fixed some duplicated functions from comments. * updated after comments * updated after comments * Fixed functional tests * Missed to add 2 changes * updated after comments * Improved design for better useability. - Added loading indicator for buttons instead of displaying all then removing few. - Added refresh on change of back end instance. - Added more restfull way of working on front end back end details endpoints. - Better handeling of some error/messages sent to GUI from front end service. - Changed name of "Subscription Handeling" to just "Subscriptions" to be more generic. * Merge * Fix of path variable name * Improved useability and reduced read from disk * Improved useability and reduced read from disk * . * Improved error handeling, added some code comments * Fixed bug with name validation, better validations. * Fixed invalid id on one message * Renamed a class * refactor names of test methods Made name of test methods to start with small letter. Tweaks and fixes to the CSS in EI frontend. (#74) * Tweaks and fixes to the CSS in EI frontend. Update frontend example image (#76) refactor names of test methods Made name of test methods to start with small letter. Tweaks and fixes to the CSS in EI frontend. (#74) * Tweaks and fixes to the CSS in EI frontend. Improved error handeling and added some code comments. (#71) * Fix multiple users may use frontend, request outside web gui. - Funktion to sent backend url as parameter added. - Gui users may now switch backend without affecting each other. - Before saving new instances the code will check if any new instances has been added to not overwrite instances created by other users. - switch-backend delete now recieves the backend to delete and not the backends to not delete. - If file is invalid or non existand it will be recreated. - Default back end properties may be specified in application-properties. - Default parameters may not be removed from gui but must be removed from application-properties first. - Unit tests have been added and updated. * Modified functional tests to work with the new utils changes. * Fixed some functional tests. * fixed code comments * Updated after comments * Fixed minor issues with switching back end * Added unittest for curl commando possibilities. * Extended time out to 11s * fixed some duplicated functions from comments. * updated after comments * updated after comments * Fixed functional tests * Missed to add 2 changes * updated after comments * Improved design for better useability. - Added loading indicator for buttons instead of displaying all then removing few. - Added refresh on change of back end instance. - Added more restfull way of working on front end back end details endpoints. - Better handeling of some error/messages sent to GUI from front end service. - Changed name of "Subscription Handeling" to just "Subscriptions" to be more generic. * Merge * Fix of path variable name * Improved useability and reduced read from disk * Improved useability and reduced read from disk * . * Improved error handeling, added some code comments * Fixed bug with name validation, better validations. * Fixed invalid id on one message * Renamed a class Update frontend example image (#76) * Added error messages from back end when adding subs. * updated after comments * updated after comments
diff --git a/src/main/resources/static/js/subscription.js b/src/main/resources/static/js/subscription.js
@@ -832,6 +832,8 @@ jQuery(document).ready(function () {
         }
         // If errors return.
         if (error) {
+            $('#errorExists').text("Required fields not filled or invalid data");
+            $('#errorExists').show();
             return;
         }
         //END: Check of other subscription fields values
@@ -867,9 +869,13 @@ jQuery(document).ready(function () {
             },
             error: function (XMLHttpRequest, textStatus, errorThrown) {
                 var responseJSON = JSON.parse(XMLHttpRequest.responseText);
+                var errors = "";
                 for (var i = 0; i < responseJSON.length; i++) {
+                    errors = errors + "\n" + responseJSON[i].reason;
                     $.jGrowl(responseJSON[i].subscription + " :: " + responseJSON[i].reason, { sticky: true, theme: 'Error' });
                 }
+                $('#serverError').text(errors);
+                $('#serverError').show();
             },
             complete: function () {
                 $('#btnSave').text('save'); //change button text
diff --git a/src/main/resources/templates/subscription.html b/src/main/resources/templates/subscription.html
@@ -288,7 +288,7 @@ <h5 style="display:inline">AND</h5>
                                         </div>
                                         <!-- /ko -->
 
-                                        <textarea data-toggle="tooltip" title="Write a Subscription Rule(JmePath)" data-bind="textInput:$data.jmespath()" name="jmespath"
+                                        <textarea data-toggle="tooltip" title="Write a Subscription Rule(JmesPath)" data-bind="textInput:$data.jmespath()" name="jmespath"
                                             placeholder="jmespath" class="form-control" type="text"></textarea>
                                         <div class="pt-1 d-flex justify-content-end">
 
@@ -321,6 +321,8 @@ <h5 style="display:inline">AND</h5>
                     </form>
                 </div>
                 <div class="modal-footer">
+                    <font class="addSubscriptionErrors" id="errorExists" color="red" size="3" />
+                    <font class="addSubscriptionErrors" id="serverError" color="red" size="3" />
                     <button data-toggle="tooltip" title="Save the changes to EI." type="button" id="btnSave" class="btn btn-primary save_record">
                         Save
                     </button>
