Skip to content

Commit 578b15f

Browse files
Some fixes (#35)
1 parent e93a6b0 commit 578b15f

File tree

5 files changed

+24
-30
lines changed

5 files changed

+24
-30
lines changed

src/main/java/com/ericsson/ei/frontend/EIRequestsController.java

Lines changed: 20 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -54,20 +54,15 @@ public class EIRequestsController {
5454
private BackEndInformation backEndInformation;
5555

5656
/**
57-
* Bridge authorized EI Http Requests with GET method. Used for login and logout
57+
* Bridge all EI Http Requests with GET method. Used for fetching
58+
* Subscription by id or all subscriptions and EI Env Info.
5859
*/
5960
@CrossOrigin
60-
@RequestMapping(value = "/auth/login", method = RequestMethod.GET)
61-
public ResponseEntity<String> getAuthRequests(Model model, HttpServletRequest request) {
61+
@RequestMapping(value = { "/subscriptions", "/subscriptions/*", "/information", "/download/*", "/auth",
62+
"/auth/*", "/queryAggregatedObject", "/queryMissedNotifications", "/query" }, method = RequestMethod.GET)
63+
public ResponseEntity<String> getRequests(Model model, HttpServletRequest request) {
6264
String eiRequestUrl = getEIRequestURL(request);
6365

64-
try {
65-
client.close();
66-
client = HttpClientBuilder.create().build();
67-
} catch (IOException e) {
68-
LOG.error("Failed to close HTTP Client");
69-
}
70-
7166
HttpGet eiRequest = new HttpGet(eiRequestUrl);
7267

7368
String header = request.getHeader("Authorization");
@@ -78,21 +73,6 @@ public ResponseEntity<String> getAuthRequests(Model model, HttpServletRequest re
7873
return getResponse(eiRequest);
7974
}
8075

81-
/**
82-
* Bridge all EI Http Requests with GET method. Used for fetching
83-
* Subscription by id or all subscriptions and EI Env Info.
84-
*/
85-
@CrossOrigin
86-
@RequestMapping(value = { "/subscriptions", "/subscriptions/*", "/information", "/download/*", "/auth",
87-
"/auth/checkStatus", "/auth/logout", "/queryAggregatedObject", "/queryMissedNotifications", "/query" }, method = RequestMethod.GET)
88-
public ResponseEntity<String> getRequests(Model model, HttpServletRequest request) {
89-
String eiRequestUrl = getEIRequestURL(request);
90-
91-
HttpGet eiRequest = new HttpGet(eiRequestUrl);
92-
93-
return getResponse(eiRequest);
94-
}
95-
9676
/**
9777
* Bridge all EI Http Requests with POST method.
9878
*/
@@ -116,6 +96,11 @@ public ResponseEntity<String> postRequests(Model model, HttpServletRequest reque
11696
eiRequest.setEntity(inputReqJsonEntity);
11797
eiRequest.setHeader("Content-type", "application/json");
11898

99+
String header = request.getHeader("Authorization");
100+
if (header != null) {
101+
eiRequest.addHeader("Authorization", header);
102+
}
103+
119104
return getResponse(eiRequest);
120105
}
121106

@@ -143,6 +128,11 @@ public ResponseEntity<String> putRequests(Model model, HttpServletRequest reques
143128
eiRequest.setEntity(inputReqJsonEntity);
144129
eiRequest.setHeader("Content-type", "application/json");
145130

131+
String header = request.getHeader("Authorization");
132+
if (header != null) {
133+
eiRequest.addHeader("Authorization", header);
134+
}
135+
146136
return getResponse(eiRequest);
147137
}
148138

@@ -157,6 +147,11 @@ public ResponseEntity<String> deleteRequests(Model model, HttpServletRequest req
157147

158148
HttpDelete eiRequest = new HttpDelete(eiRequestUrl);
159149

150+
String header = request.getHeader("Authorization");
151+
if (header != null) {
152+
eiRequest.addHeader("Authorization", header);
153+
}
154+
160155
return getResponse(eiRequest);
161156
}
162157

src/main/java/com/ericsson/ei/frontend/utils/BackEndInstancesUtils.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,8 @@
2929
import org.springframework.stereotype.Component;
3030

3131
import javax.annotation.PostConstruct;
32-
import java.io.FileWriter;
3332
import java.io.IOException;
3433
import java.nio.file.Files;
35-
import java.nio.file.Path;
3634
import java.nio.file.Paths;
3735
import java.util.ArrayList;
3836
import java.util.List;

src/main/resources/application.properties

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@ ei.useSecureHttp=false
2222
ei.backendInstancesPath=
2323

2424
###### EI Documentation Link Url ##########
25-
ei.eiffelDocumentationUrls={ "EI GitHub": "https://github.com/Ericsson/eiffel-intelligence-frontend",\
25+
ei.eiffelDocumentationUrls={ "EI Frontend GitHub": "https://github.com/Ericsson/eiffel-intelligence-frontend",\
26+
"EI Backend GitHub": "https://github.com/Ericsson/eiffel-intelligence",\
2627
"Eiffel Github": "https://github.com/Ericsson/eiffel",\
2728
"Eiffel Github main page": "http://ericsson.github.io/eiffel" }
2829

src/main/resources/static/js/subscription.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -485,7 +485,7 @@ jQuery(document).ready(function() {
485485
event.preventDefault();
486486
function getTemplate() {
487487
var req = new XMLHttpRequest();
488-
req.open("GET", '/download/subscriptionsTemplate', true);
488+
req.open("GET", frontendServiceUrl + '/download/subscriptionsTemplate', true);
489489
req.responseType = "application/json;charset=utf-8";
490490
req.onload = function (event) {
491491
var jsonData = JSON.stringify(JSON.parse(req.response), null, 2);

src/main/resources/templates/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
<div class="hidden" style="display: none" id="frontendServiceUrl" th:text="${frontendServiceUrl}"></div>
3434
<!-- Navigation-->
3535
<nav class="navbar navbar-expand-lg navbar-dark bg-dark fixed-top" id="mainNav">
36-
<a class="navbar-brand" href="/"><img width="32" alt="Information" src="assets/images/favicon-32x32.png"/>Eiffel Intelligence</a>
36+
<a class="navbar-brand" th:href="${frontendServiceUrl}"><img width="32" alt="Information" src="assets/images/favicon-32x32.png"/>Eiffel Intelligence</a>
3737
<button class="navbar-toggler navbar-toggler-right" type="button" data-toggle="collapse" data-target="#navbarResponsive" aria-controls="navbarResponsive" aria-expanded="false" aria-label="Toggle navigation">
3838
<span class="navbar-toggler-icon"></span>
3939
</button>

0 commit comments

Comments
 (0)