Skip to content

Parameter set as endpoint in integration test #49

@ghost

Description

Description

In ServiceIntegrationSteps.java line 208 the parameter account_id=1000000 is set using .setEndpoint(). This will not work when upgrading eiffel-commons to the latest version. To be able to run integarion tests after updating eiffel-commons version the account_id parameter must be set using addParameter method.

Motivation

Integration test will not work if eiffel-commons is updated to latest version.

Exemplification

Make the code look more decent.

final HttpRequest requestLogin = new HttpRequest(HttpMethod.GET, httpExecutor);

requestLogin.setBaseUrl(GERRIT_BASE_URL)
            .setEndpoint("/login/")
            .addParameter("account_id", "1000000")
            .addParameter("http.protocol.handle-redirects", "false");

final ResponseEntity response = requestLogin.performRequest();

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers to start with

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions