Add more test coverage (#44)

* Add unit tests for the JenkinsManager and FileUtils class
* Add missing copyright headers
* Some minor fixes to solve codacy complaints

Author: Christoffer-Cortes

src/main/java/com/ericsson/eiffelcommons/constants/RegExProvider.java

@@ -1,3 +1,19 @@
+/*
+   Copyright 2019 Ericsson AB.
+   For a full list of individual contributors, please see the commit history.
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+*/
 package com.ericsson.eiffelcommons.constants;
 
 public final class RegExProvider {

src/main/java/com/ericsson/eiffelcommons/exceptions/JenkinsManagerException.java

@@ -0,0 +1,35 @@
+/*
+   Copyright 2020 Ericsson AB.
+   For a full list of individual contributors, please see the commit history.
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+*/
+package com.ericsson.eiffelcommons.exceptions;
+
+public class JenkinsManagerException extends Exception {
+
+    private static final long serialVersionUID = 2L;
+
+    public JenkinsManagerException() {
+        super();
+    }
+
+    public JenkinsManagerException(String message) {
+        super(message);
+    }
+
+    public JenkinsManagerException(String message, Throwable e) {
+        super(message, e);
+    }
+
+}

src/main/java/com/ericsson/eiffelcommons/http/HttpRequest.java

@@ -136,8 +136,7 @@ public String getBaseUrl() {
      * @param baseUrl
      */
     public HttpRequest setBaseUrl(String baseUrl) {
-        baseUrl = trimBaseUrl(baseUrl);
-        this.baseUrl = baseUrl;
+        this.baseUrl = trimBaseUrl(baseUrl);
         return this;
     }
 
@@ -350,13 +349,14 @@ private URI addParametersToURI(URI oldUri) throws URISyntaxException {
     /**
      * Function that trims the base url for trailing slashes
      *
-     * @return HttpRequest
+     * @return trimmedUrl
      */
     private String trimBaseUrl(String baseUrl) {
+        String trimmedUrl = baseUrl;
         if (baseUrl.endsWith("/")) {
-            baseUrl = baseUrl.substring(0, baseUrl.length() - 1);
+            trimmedUrl = baseUrl.substring(0, baseUrl.length() - 1);
         }
 
-        return baseUrl;
+        return trimmedUrl;
     }
 }