Skip to content

Commit 4551214

Browse files
authored
Fix failing test cases (#66) (#67)
1 parent d6f77f6 commit 4551214

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/test/java/com/ericsson/eiffelcommons/http/HttpRequestTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
import com.ericsson.eiffelcommons.http.HttpRequest.HttpMethod;
3232

3333
public class HttpRequestTest {
34-
private static final String URL_1 = "http://something.com";
34+
private static final String URL_1 = "http://some0thing.com";
3535
private static final String URL_2 = "http://something.com/";
3636
private static final String URL_BAD_PROTOCOL = "httpl://something.com/";
3737
private static final String URL_BAD_SYNTAX = "http:<<something.com/";
@@ -57,7 +57,7 @@ public class HttpRequestTest {
5757
@Test
5858
public void testBuildingOfURI() throws Exception {
5959
HttpRequest request = new HttpRequest(HttpMethod.POST);
60-
request.setBaseUrl(URL_1);
60+
request.setBaseUrl(URL_2);
6161
request.setEndpoint(ENDPOINT_1);
6262
URIBuilder builder = (URIBuilder) Whitebox.invokeMethod(request, "createURIBuilder");
6363
assertEquals(EXPECTED_URI, builder.toString());
@@ -75,7 +75,7 @@ public void testBuildingOfURI() throws Exception {
7575
assertEquals(EXPECTED_URI, builder.toString());
7676

7777
request = new HttpRequest(HttpMethod.PUT);
78-
request.setBaseUrl(URL_1);
78+
request.setBaseUrl(URL_2);
7979
request.setEndpoint(ENDPOINT_2);
8080
builder = (URIBuilder) Whitebox.invokeMethod(request, "createURIBuilder");
8181
assertEquals(EXPECTED_URI, builder.toString());

src/test/java/com/ericsson/eiffelcommons/jenkins/JenkinsManagerTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99

1010
import java.io.IOException;
1111
import java.io.UnsupportedEncodingException;
12-
import java.net.MalformedURLException;
1312
import java.net.ServerSocket;
1413
import java.net.URISyntaxException;
1514
import java.net.UnknownHostException;
@@ -20,6 +19,7 @@
2019
import javax.xml.bind.DatatypeConverter;
2120

2221
import org.apache.http.client.ClientProtocolException;
22+
import org.apache.http.conn.UnsupportedSchemeException;
2323
import org.json.JSONException;
2424
import org.json.JSONObject;
2525
import org.junit.BeforeClass;
@@ -33,11 +33,11 @@ public class JenkinsManagerTest {
3333

3434
private static final String UNKNOWN_HOST = "!¤€31";
3535
private static final int PORT_OUT_OF_RANGE = 1000000;
36-
private static final String INVALID_PROTOCOL = "httg";
3736
private static final String URL = "http://localhost";
3837
private static final String USERNAME = "username";
3938
private static final String PASSWORD = "password";
4039
private static final String PROTOCOL = "http";
40+
private static final String INVALID_PROTOCOL = "httg";
4141
private static final String HOST = "localhost";
4242
private static final String ENDPOINT_CRUMB = "/crumbIssuer/api/json";
4343
private static final String RESPONSE_CRUMB = "{\"crumb\":\"fb171d526b9cc9e25afe80b356e12cb7\",\"crumbRequestField\":\".crumb\"}";
@@ -119,7 +119,7 @@ public void jenkinsManagerConstructorFailCrumb()
119119
assertEquals("", actualCrumb);
120120
}
121121

122-
@Test(expected = MalformedURLException.class)
122+
@Test(expected = UnsupportedSchemeException.class)
123123
public void jenkinsManagerConstructorInvalidProtocol()
124124
throws ClientProtocolException, URISyntaxException, IOException {
125125
new JenkinsManager(INVALID_PROTOCOL, HOST, port, USERNAME, PASSWORD);

0 commit comments

Comments
 (0)